Test: carry uwreqs.challenge_id in the swap-scenario fixture - #68
Merged
Conversation
…xture wire-sysio#549 adds `challenge_id` to both `uw_request_t` and the `locks` row, and the regenerated `sdk-core` types carry it as a required property on `SysioUwritUwRequestTType` and `SysioUwritLockEntryType`. #56 added the field to `lockRow()` but not to `uwreqRow()`. Both return the full row type rather than a `Partial`, so the omission stops `packages/cluster-tool` compiling — `tsc -b` fails with TS2322 and takes `pnpm build` with it, which is why every e2e run since the companion merges dies in the platform build before a single flow starts. That fixture is the whole surface: `uwreqRow()` and `lockRow()` are the only positions in the repo that construct these rows; every other `SysioUwritUwRequestTType` reference is a read position.
jglanz
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterdoes not compile. Every E2E run since the underwriter-challenge merges dies in the platform build, before a single flow starts:Cause
wire-sysio#549 adds
challenge_idto bothuw_request_tand thelocksrow — the markerholdlocksstamps while an underwriter-fault challenge is open. wire-libraries-ts#61 regeneratedSysioContractTypes, so the field is a required property onSysioUwritUwRequestTTypeandSysioUwritLockEntryType.#56 carried the new field into
lockRow()but not intouwreqRow(). Both fixtures return the full row type rather than aPartial, so the omission failstsc -binpackages/cluster-tooland takespnpm build— and the E2E gate behind it — down with it.Same break as #58, which added
target_amountto this same fixture for the same reason.Fix
attestation_outbound_data: "", + challenge_id: 0, ...overridesScope
uwreqRow()andlockRow()are the only positions in the repo that construct these rows; every otherSysioUwritUwRequestTTypereference is a read position. Key-diffing every generated-type literal in the tree against thewire-libraries-tsmaster interfaces leaves nothing else short a required field:reserveRow22/22,uwreqRow23/23 with this line,lockRow10/10, and the threeSysioSystem*/SysioBios*literals in the orchestration tests complete.