You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Support Forums: Redirect paginated topic URLs to add the trailing slash - #1208
/support/topic/<slug>/page/2 (no trailing slash) returns a 200 instead of a 301 to /support/topic/<slug>/page/2/.
Core's redirect_canonical() would add the slash, but bbPress turns it off on paginated single topics: bbp_do_not_redirect_paginations() on the bbp_redirect_canonical filter returns an empty URL when bbp_get_paged() is above 1 on a single topic. So nothing adds the slash on page 2 and later. The topic URL itself and page 1 are already redirected.
This adds redirect_topic_page_trailing_slash() on bbp_template_redirect, next to redirect_page_zero_one(). On a paginated single topic it sends a 301 to the user_trailingslashit() form of the request path, with the query string kept. POST requests are left alone.
/topic/<slug>/page/2: 301 to /topic/<slug>/page/2/
/topic/<slug>/page/2?replies=1&foo=bar: 301 to /topic/<slug>/page/2/?replies=1&foo=bar
/topic/<slug>/page/2/: 200, unchanged
The Location header is the request path (relative), so it stays right under the /support/ site path.
A Playwright run against the local environment failed on trunk with Expected: 301 Received: 200 (3 failed, 1 passed) and passes with this change (4 passed).
AI assistance: Yes. Tool: Claude Code. Used for: finding the cause and drafting the change; I reviewed and tested it myself.
Summary by CodeRabbit
Bug Fixes
Paginated topic pages now use consistent trailing-slash URLs. Visitors arriving at older URL formats are redirected to the corresponding page, with query parameters preserved.
bbPress turns off redirect_canonical() on paginated single topics, so
/topic/<slug>/page/2 answered with a 200 instead of a redirect. Send a
301 to the user_trailingslashit() form of the path, keeping the query
string.
See https://meta.trac.wordpress.org/ticket/5322
No actionable comments were generated in the recent review.
Walkthrough
The plugin registers a redirect for paginated single-topic requests. For eligible requests, it adds the paged trailing-slash format to the path and issues a 301 redirect while preserving the query string.
Changes: Paginated topic redirect
Layer / File(s)
Summary
Register and apply topic redirect wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-performance-optimizations.php
The constructor registers the redirect on bbp_template_redirect. For non-POST requests on single-topic pages numbered 2 or higher, the callback sanitizes the request URI and issues a 301 redirect if the formatted path changes. The redirect preserves the query string.
The redirect appears mergeable after normal checks.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the main change: paginated single-topic URLs without a trailing slash are redirected to the trailing-slash form. The raw summary confirms a new redirect_topic_page_trailing_slash() met…
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: paginated single-topic URLs without a trailing slash are redirected to the trailing-slash form. The raw summary confirms a new redirect_topic_page_trailing_slash() method that issues a 301 for non-POST requests on topic pages numbered 2 or higher, preserves the query string, and is registered on bbp_template_redirect. The objectives describe the same behavior and the same ticket. The title is specific and matches the changeset.
Full details: Docstring Coverage
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://meta.trac.wordpress.org/ticket/5322
/support/topic/<slug>/page/2(no trailing slash) returns a 200 instead of a 301 to/support/topic/<slug>/page/2/.Core's
redirect_canonical()would add the slash, but bbPress turns it off on paginated single topics:bbp_do_not_redirect_paginations()on thebbp_redirect_canonicalfilter returns an empty URL whenbbp_get_paged()is above 1 on a single topic. So nothing adds the slash on page 2 and later. The topic URL itself and page 1 are already redirected.This adds
redirect_topic_page_trailing_slash()onbbp_template_redirect, next toredirect_page_zero_one(). On a paginated single topic it sends a 301 to theuser_trailingslashit()form of the request path, with the query string kept. POST requests are left alone./topic/<slug>/page/2: 301 to/topic/<slug>/page/2//topic/<slug>/page/2?replies=1&foo=bar: 301 to/topic/<slug>/page/2/?replies=1&foo=bar/topic/<slug>/page/2/: 200, unchangedThe
Locationheader is the request path (relative), so it stays right under the/support/site path.Testing
npm run support:env startinenvironments/. (On Docker Desktop this currently fails on thewporg-ratings.phpmount; Environments: Fix jobs, WordPress.tv and Support Forums envs failing to start #1205 fixes that.)curl -sI http://localhost:8888/topic/<slug>/page/2shows301andLocation: /topic/<slug>/page/2/.curl -sI http://localhost:8888/topic/<slug>/page/2/shows200.A Playwright run against the local environment failed on trunk with
Expected: 301 Received: 200(3 failed, 1 passed) and passes with this change (4 passed).AI assistance: Yes. Tool: Claude Code. Used for: finding the cause and drafting the change; I reviewed and tested it myself.
Summary by CodeRabbit