Skip to content

build: Add PatchNixBinary util to make it easier to patch binaries#7539

Draft
mathbunnyru wants to merge 1 commit into
XRPLF:developfrom
mathbunnyru:add_patch_nix_binary
Draft

build: Add PatchNixBinary util to make it easier to patch binaries#7539
mathbunnyru wants to merge 1 commit into
XRPLF:developfrom
mathbunnyru:add_patch_nix_binary

Conversation

@mathbunnyru

Copy link
Copy Markdown
Contributor

High Level Overview of Change

I want our image to always produce the expected binary, and not require external patching.
This would also mean that if someone builds locally in CI image, they will not forget to patch binary.

Context of Change

In Clio, we package using cpack, and when I wanted to start using our images, I had to do it this way, otherwise we would pack unpatched binary.
And I think it's a good idea here as well, so backporting this change.

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mathbunnyru mathbunnyru added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Jun 15, 2026
@mathbunnyru mathbunnyru marked this pull request as draft June 15, 2026 14:05
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.0%. Comparing base (df395d6) to head (33057a4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #7539     +/-   ##
=========================================
- Coverage     82.0%   82.0%   -0.0%     
=========================================
  Files         1009    1009             
  Lines        76779   76779             
  Branches      8937    8935      -2     
=========================================
- Hits         62978   62974      -4     
- Misses       13792   13796      +4     
  Partials         9       9             

see 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DraftRunCI Normally CI does not run on draft PRs. This opts in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant