build: Add PatchNixBinary util to make it easier to patch binaries#7539
Draft
mathbunnyru wants to merge 1 commit into
Draft
build: Add PatchNixBinary util to make it easier to patch binaries#7539mathbunnyru wants to merge 1 commit into
mathbunnyru wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7539 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.0%
=========================================
Files 1009 1009
Lines 76779 76779
Branches 8937 8935 -2
=========================================
- Hits 62978 62974 -4
- Misses 13792 13796 +4
Partials 9 9 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
I want our image to always produce the expected binary, and not require external patching.
This would also mean that if someone builds locally in CI image, they will not forget to patch binary.
Context of Change
In Clio, we package using cpack, and when I wanted to start using our images, I had to do it this way, otherwise we would pack unpatched binary.
And I think it's a good idea here as well, so backporting this change.
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)