Added type checks: if (!params[jss::channel_id].isString()) return rpcError(rpcINVALID_PARAMS); and similarly for signature.#7582
Open
harshitgupta62 wants to merge 1 commit into
Conversation
|
If only the most recent commit is unsigned, you can run:
If multiple commits are unsigned, you can run:
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
9065bc3 to
402841f
Compare
…pcError(rpcINVALID_PARAMS); and similarly for signature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Fixes #6765
Adds
isString()type validation checks before callingasString()on the
channel_idparameter inChannelAuthorize.cppand on bothchannel_idandsignatureparameters inChannelVerify.cpp.Previously, non-string inputs (e.g. integers, arrays) could be
silently coerced or cause unexpected behavior. Now, invalid types
return
rpcINVALID_PARAMSimmediately, consistent with the existingpattern used for the
amountfield in the same handlers.