Skip to content

Sponsorship xls 68 #3238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cybele-ripple wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Sponsorship xls 68 #3238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
94192c1
initial commit for XLS 82d
cybele-ripple Mar 25, 2026
b2547ae
changes based on initial agent review
cybele-ripple Mar 26, 2026
22a0ecf
resolved issues from tests
cybele-ripple Mar 30, 2026
5dbd855
coderabbit fixes
cybele-ripple Mar 30, 2026
93f5476
fix return type in sign
cybele-ripple Mar 30, 2026
2022d46
resolve error based on big number
cybele-ripple Mar 31, 2026
e86d7da
resolve issues related to lint
cybele-ripple Mar 31, 2026
bfce3b7
code rabbit comments addressed
cybele-ripple Apr 10, 2026
2ac8673
linter fix
cybele-ripple Apr 10, 2026
2eeb54a
linter fixes
cybele-ripple Apr 10, 2026
b8dfd79
Merge branch 'main' into sponsorship-XLS-68
cybele-ripple Apr 16, 2026
72cc2d5
feat(xls-68): align sponsor fields and account_sponsoring params with…
cybele-ripple Apr 22, 2026
09351e1
fix(xls-68): correct Sponsorship ledger entry code and point CI at sp…
cybele-ripple Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
name: Node.js CI

env:
RIPPLED_DOCKER_IMAGE: rippleci/rippled:develop
RIPPLED_DOCKER_IMAGE: legleux/xrpld:sponsor
GIT_REF: ${{ inputs.git_ref || github.ref }}

on:
Expand Down
153 changes: 153 additions & 0 deletions packages/ripple-binary-codec/src/enums/definitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,26 @@
"type": "Amount"
}
],
[
"FeeAmount",
{
"isSerialized": true,
"isSigningField": true,
"isVLEncoded": false,
"nth": 32,
"type": "Amount"
}
],
[
"MaxFee",
{
"isSerialized": true,
"isSigningField": true,
"isVLEncoded": false,
"nth": 33,
"type": "Amount"
}
],
[
"LedgerEntryType",
{
Expand Down Expand Up @@ -850,6 +870,56 @@
"type": "UInt32"
}
],
[
"SponsorFlags",
{
"isSerialized": true,
"isSigningField": true,
"isVLEncoded": false,
"nth": 73,
"type": "UInt32"
}
],
[
"SponsoredOwnerCount",
{
"isSerialized": true,
"isSigningField": true,
"isVLEncoded": false,
"nth": 69,
"type": "UInt32"
}
],
[
"SponsoringOwnerCount",
{
"isSerialized": true,
"isSigningField": true,
"isVLEncoded": false,
"nth": 70,
"type": "UInt32"
}
],
[
"SponsoringAccountCount",
{
"isSerialized": true,
"isSigningField": true,
"isVLEncoded": false,
"nth": 71,
"type": "UInt32"
}
],
[
"ReserveCount",
{
"isSerialized": true,
"isSigningField": true,
"isVLEncoded": false,
"nth": 72,
"type": "UInt32"
}
],
[
"IndexNext",
{
Expand Down Expand Up @@ -1140,6 +1210,16 @@
"type": "UInt64"
}
],
[
"SponseeNode",
{
"isSerialized": true,
"isSigningField": true,
"isVLEncoded": false,
"nth": 32,
"type": "UInt64"
}
],
[
"EmailHash",
{
Expand Down Expand Up @@ -1510,6 +1590,16 @@
"type": "Hash256"
}
],
[
"ObjectID",
{
"isSerialized": true,
"isSigningField": true,
"isVLEncoded": false,
"nth": 39,
"type": "Hash256"
}
],
[
"hash",
{
Expand Down Expand Up @@ -2310,6 +2400,56 @@
"type": "AccountID"
}
],
[
"Sponsor",
{
"isSerialized": true,
"isSigningField": true,
"isVLEncoded": true,
"nth": 27,
"type": "AccountID"
}
],
[
"HighSponsor",
{
"isSerialized": true,
"isSigningField": true,
"isVLEncoded": true,
"nth": 28,
"type": "AccountID"
}
],
[
"LowSponsor",
{
"isSerialized": true,
"isSigningField": true,
"isVLEncoded": true,
"nth": 29,
"type": "AccountID"
}
],
[
"CounterpartySponsor",
{
"isSerialized": true,
"isSigningField": true,
"isVLEncoded": true,
"nth": 30,
"type": "AccountID"
}
],
[
"Sponsee",
{
"isSerialized": true,
"isSigningField": true,
"isVLEncoded": true,
"nth": 31,
"type": "AccountID"
}
],
[
"Number",
{
Expand Down Expand Up @@ -2840,6 +2980,16 @@
"type": "STObject"
}
],
[
"SponsorSignature",
{
"isSerialized": true,
"isSigningField": false,
"isVLEncoded": false,
"nth": 38,
"type": "STObject"
}
],
[
"Signers",
{
Expand Down Expand Up @@ -3459,6 +3609,7 @@
"PermissionedDomain": 130,
"RippleState": 114,
"SignerList": 83,
"Sponsorship": 144,
"Ticket": 84,
"Vault": 132,
"XChainOwnedClaimID": 113,
Expand Down Expand Up @@ -3720,6 +3871,8 @@
"SetFee": 101,
"SetRegularKey": 5,
"SignerListSet": 12,
"SponsorshipSet": 86,
"SponsorshipTransfer": 85,
"TicketCreate": 10,
"TrustSet": 20,
"UNLModify": 102,
Expand Down
3 changes: 2 additions & 1 deletion packages/ripple-keypairs/src/signing-schemes/secp256k1/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,11 @@ const secp256k1: SigningScheme = {
lowS: true,
// Would fail tests if signatures aren't deterministic
extraEntropy: undefined,
format: 'der',
// We pass a pre-hashed message (Sha512Half), so disable secp256k1's
// default SHA-256 prehashing (added as default in @noble/curves 2.0.0)
prehash: false,
// Return DER-encoded signature bytes
format: 'der',
}),
).toUpperCase()
},
Expand Down
6 changes: 6 additions & 0 deletions packages/xrpl/src/Wallet/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,3 +486,9 @@ export {
signLoanSetByCounterparty,
combineLoanSetCounterpartySigners,
} from './counterpartySigner'

export {
signAsSponsor,
combineSponsorSigners,
addPreFundedSponsor,
} from './sponsorSigner'
Loading