[depthfirst-2536] Upgrade lodash to 4.18.0#3326
Closed
depthfirst-app[bot] wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Close as lodash has been upgraded in #3271 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Upgrade lodash to 4.18.1 in packages/xrpl
Upgrade
lodashdependency from^4.17.4to^4.18.0inpackages/xrpl/package.json.package-lock.jsonto resolve and install version4.18.1. This version satisfies the new constraint, resolving high-severity security vulnerabilities while remaining compatible with previous 4.x versions.Changes
lodashinpackages/xrpl/package.json.package-lock.jsonto properly lock the new4.18.1version and its integrity hash globally.Warnings
constructorandprototypeare now unconditionally blocked as non-terminal path keys in_.unsetand_.omit._.templateimports will now throw an"Invalid imports option passed into _.template"error.Next Steps
Vulnerabilities Fixed
lodash vulnerable to Prototype Pollution via array path bypass in
_.unsetand_.omit_.unsetand_.omit_.unsetand_.omitfunctions. The fix for CVE-2025-13465 only guarded against string key members, allowing an attacker to bypass the check by passing array-wrapped path segments. This allows the deletion of properties from built-in prototypes such asObject.prototype,Number.prototype, andString.prototype. The issue permits deletion of prototype properties but does not allow overwriting their original behavior.lodash vulnerable to Code Injection via
_.templateimports key names_.templateimports key namesvariableoption in_.templatebut did not apply the same validation tooptions.importskey names. Both paths flow into the sameFunction()constructor sink. When an application passes untrusted input asoptions.importskey names, an attacker can inject default-parameter expressions that execute arbitrary code at template compilation time. Additionally,_.templateusedassignInWithto merge imports, which enumerated inherited properties viafor..in. IfObject.prototypehad been polluted, the polluted keys were copied into the imports object and passed toFunction().