VLC Video sync and cleanup

.editorconfig

@@ -150,6 +150,11 @@ tab_width = 4
 indent_style = tab
 tab_width = 4
 
+[manifest.json]
+charset = utf-8
+indent_style = space
+indent_size = 2
+
 [*.inputactions]
 indent_style = tab
 tab_width = 4

.gitattributes

@@ -7,6 +7,7 @@
 *.prefab eol=lf
 ProjectSettings/* eol=lf
 ProjectSettings/**/* eol=lf
+*.sh text eol=lf
 
 # Items that should be stored in LFS
 *.png filter=lfs diff=lfs merge=lfs -text

.github/pull_request_template.md

@@ -0,0 +1,13 @@
+## Description
+<!-- Briefly describe the changes in this pull request in your own words. -->
+
+
+## Screenshots or Video
+<!-- Add screenshots or a video recording if this PR introduces visual or UI changes. -->
+
+
+## YARG.Core PR (if applicable)
+<!-- If this change depends on a YARG.Core PR, link to it here. -->
+
+
+<!-- Tip: Please make sure not to include YARG.Core pointer updates in your PR. -->

.github/workflows/label-conflicts.yml

@@ -0,0 +1,103 @@
+name: Auto Label Merge Conflicts
+
+on:
+  push:
+    branches:
+      - dev
+  pull_request_target:
+    types: [opened, synchronize, reopened]
+
+concurrency:
+  group: label-conflicts-${{ github.repository }}-${{ github.event.pull_request.number || 'all' }}
+  cancel-in-progress: true
+
+jobs:
+  label-conflicts:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      pull-requests: write
+    steps:
+      - name: Check and Label Conflicting PRs
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          GH_REPO: ${{ github.repository }}
+          PR_NUMBER: ${{ github.event.pull_request.number }}
+        run: |
+          fetch_prs() {
+            if [ -n "$PR_NUMBER" ]; then
+              gh api graphql -f query='
+                query($owner: String!, $repo: String!, $number: Int!) {
+                  repository(owner: $owner, name: $repo) {
+                    pullRequest(number: $number) {
+                      number
+                      title
+                      mergeable
+                      labels(first: 100) {
+                        nodes { name }
+                      }
+                    }
+                  }
+                }' -F owner="${GH_REPO%/*}" -F repo="${GH_REPO#*/}" -F number="$PR_NUMBER" \
+                | jq -c '[.data.repository.pullRequest] | map(select(. != null))'
+            else
+              gh api graphql -f query='
+                query($owner: String!, $repo: String!) {
+                  repository(owner: $owner, name: $repo) {
+                    pullRequests(states: OPEN, first: 100) {
+                      nodes {
+                        number
+                        title
+                        mergeable
+                        labels(first: 100) {
+                          nodes { name }
+                        }
+                      }
+                    }
+                  }
+                }' -F owner="${GH_REPO%/*}" -F repo="${GH_REPO#*/}" \
+                | jq -c '.data.repository.pullRequests.nodes'
+            fi
+          }
+
+          # GitHub may still be calculating mergeability immediately after a push.
+          for attempt in {1..4}; do
+            PRS=$(fetch_prs)
+            UNKNOWN_COUNT=$(echo "$PRS" | jq -r '[.[] | select(.mergeable == "UNKNOWN")] | length')
+
+            if [ "$UNKNOWN_COUNT" -eq 0 ] || [ "$attempt" -eq 4 ]; then
+              break
+            fi
+
+            echo "Waiting 10s for GitHub to compute merge status for $UNKNOWN_COUNT PR(s)... (attempt $attempt/4)"
+            sleep 10
+          done
+
+          TOTAL=$(echo "$PRS" | jq -r 'length')
+          echo "Checking $TOTAL pull request(s)."
+
+          if [ "$TOTAL" -eq 0 ]; then
+            echo "No open PRs to process."
+            exit 0
+          fi
+
+          echo "$PRS" | jq -c '.[]' | while read -r pr; do
+            NUMBER=$(echo "$pr" | jq -r '.number')
+            TITLE=$(echo "$pr" | jq -r '.title')
+            MERGEABLE=$(echo "$pr" | jq -r '.mergeable')
+            HAS_LABEL=$(echo "$pr" | jq -r 'any(.labels.nodes[]; .name == "Has Conflicts")')
+
+            if [ "$MERGEABLE" = "CONFLICTING" ] && [ "$HAS_LABEL" = "false" ]; then
+              echo "PR #$NUMBER ($TITLE) has conflicts -> Adding 'Has Conflicts' label"
+              gh pr edit "$NUMBER" --add-label "Has Conflicts"
+            elif [ "$MERGEABLE" = "MERGEABLE" ] && [ "$HAS_LABEL" = "true" ]; then
+              echo "PR #$NUMBER ($TITLE) is clean -> Removing 'Has Conflicts' label"
+              gh pr edit "$NUMBER" --remove-label "Has Conflicts"
+            elif [ "$MERGEABLE" = "CONFLICTING" ]; then
+              echo "PR #$NUMBER ($TITLE) still has conflicts -> Label unchanged"
+            elif [ "$MERGEABLE" = "MERGEABLE" ]; then
+              echo "PR #$NUMBER ($TITLE) is still clean -> Label unchanged"
+            else
+              echo "PR #$NUMBER ($TITLE) status is $MERGEABLE -> Skipping"
+            fi
+          done

.github/workflows/native-audio.yml

@@ -0,0 +1,145 @@
+name: Native audio
+
+on:
+  pull_request:
+    paths:
+      - "Native/YargAudio/**"
+      - "Assets/Plugins/YargAudio/**"
+      - "scripts/NativeBuild/**"
+      - ".github/workflows/native-audio.yml"
+  push:
+    branches: [dev]
+    paths:
+      - "Native/YargAudio/**"
+      - "Assets/Plugins/YargAudio/**"
+      - "scripts/NativeBuild/**"
+      - ".github/workflows/native-audio.yml"
+  workflow_dispatch:
+
+permissions:
+  contents: read
+
+jobs:
+  windows:
+    name: Windows x64
+    runs-on: windows-2022
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 1
+      - name: Build, test, and package plugin
+        run: >
+          dotnet run --project scripts/NativeBuild --
+          build --output "$env:RUNNER_TEMP/yarg-audio-package" --verify-committed-plugin
+      - uses: actions/upload-artifact@v4
+        if: always()
+        with:
+          name: yarg-audio-windows-x64
+          path: ${{ runner.temp }}/yarg-audio-package
+          if-no-files-found: error
+
+  linux:
+    name: Linux x64
+    # Build inside an Ubuntu 20.04 container (glibc 2.31, gcc 11) to keep the
+    # glibc floor at 2.31, matching Unity 6's Ubuntu 20.04 support. Toolchains
+    # linked against glibc >= 2.34 emit dlopen@GLIBC_2.34 and fail to load on
+    # Ubuntu 20.04, Debian 11, and RHEL 8. Do not bump this container without
+    # re-evaluating the floor (see Native/YargAudio/README.md).
+    runs-on: ubuntu-22.04
+    container: ubuntu:20.04
+    env:
+      # apt can hang on debconf prompts (e.g. tzdata) in bare containers.
+      DEBIAN_FRONTEND: noninteractive
+    steps:
+      - name: Install toolchain (gcc 10, cmake)
+        timeout-minutes: 10
+        run: |
+          apt-get update
+          # gcc-10 ships in focal universe and supports C++20 (designated
+          # initializers, etc.); avoids the launchpad PPA keyserver.
+          apt-get install -y --no-install-recommends \
+            g++-10 git python3-pip curl ca-certificates libicu66 make \
+            file binutils
+          update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-10 100
+          update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-10 100
+          # Ubuntu 20.04 ships cmake 3.16; YargAudio requires >= 3.25.
+          # py3-none wheel bundles a fresh cmake; pinned <4 for preset compat.
+          pip3 install --no-cache-dir "cmake<4"
+          cmake --version
+          gcc --version | head -1
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 1
+      - uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: 8.x
+      - name: Build, test, and package plugin
+        run: >
+          dotnet run --project scripts/NativeBuild --
+          build --output "$RUNNER_TEMP/yarg-audio-package" --verify-committed-plugin
+      - name: Verify architecture and exports
+        run: |
+          file Native/YargAudio/build/linux-x64/libyarg_audio.so | grep 'ELF 64-bit.*x86-64'
+          nm -D --defined-only Native/YargAudio/build/linux-x64/libyarg_audio.so | grep ' yarg_gain_dsp_attach$'
+      - uses: actions/upload-artifact@v4
+        if: always()
+        with:
+          name: yarg-audio-linux-x64
+          path: ${{ runner.temp }}/yarg-audio-package
+          if-no-files-found: error
+
+  macos:
+    name: macOS universal
+    # macos-26, not -14/-15: dyld4 on macOS 26 rejects ad-hoc signatures
+    # produced by older codesign versions (Xcode 16) with SIGKILL at dlopen,
+    # and enforces the LC_UUID requirement. This runner matches what users
+    # run, so the integration test exercises the real load path.
+    runs-on: macos-26
+    env:
+      # Pin Xcode 26.0.1: its clang (17.0.0.17000319) matches what the
+      # maintainers build with, keeping the byte-identical plugin gate
+      # meaningful. Also: never ad-hoc re-sign with codesign here — dyld on
+      # macOS 26.0-26.4 SIGKILLs codesign-made signatures at dlopen; the
+      # linker's own ad-hoc signature (linker-signed) loads everywhere.
+      DEVELOPER_DIR: /Applications/Xcode_26.0.1.app/Contents/Developer
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 1
+      # xcode-select alone does not redirect the codesign shim when the image
+      # also ships newer Command Line Tools; DEVELOPER_DIR does. Kept for the
+      # clang toolchain selection even though the plugin is no longer re-signed.
+      - name: Pin Xcode 26.0.1
+        run: |
+          sudo xcode-select -s /Applications/Xcode_26.0.1.app
+          xcode-select -p
+          clang --version | head -1
+      - uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: 8.x
+      - name: Build, test, and package plugin
+        run: >
+          dotnet run --project scripts/NativeBuild --
+          build --output "$RUNNER_TEMP/yarg-audio-package" --verify-committed-plugin
+      - name: Verify architectures, load commands, and signature
+        run: |
+          lipo Native/YargAudio/build/macos-universal/libyarg_audio.dylib -verify_arch x86_64 arm64
+          nm -gU Native/YargAudio/build/macos-universal/libyarg_audio.dylib | grep ' _yarg_gain_dsp_attach$'
+          # dyld4 (macOS 15+) refuses UUID-less dylibs; guard against linker
+          # flags that strip LC_UUID for reproducibility.
+          otool -l Native/YargAudio/build/macos-universal/libyarg_audio.dylib | grep -c 'cmd LC_UUID' | grep -q '^2$'
+          # CD size identifies the codesign generation; 26.0-era is ~358,
+          # newer is ~367 and SIGKILLs at dlopen on macOS 26.0-26.4. A
+          # linker-signed (0x20002) signature is the expected good state.
+          # Note: codesign --verify cannot validate linker-signed binaries
+          # (reports "not signed at all"); the integration test's dlopen is
+          # the real load proof.
+          codesign -dv --verbose=4 Native/YargAudio/build/macos-universal/libyarg_audio.dylib 2>&1 | grep CodeDirectory
+      - name: Verify Intel (x86_64) slice under Rosetta
+        run: arch -x86_64 Native/YargAudio/build/macos-universal/yarg_audio_tests
+      - uses: actions/upload-artifact@v4
+        if: always()
+        with:
+          name: yarg-audio-macos-universal
+          path: ${{ runner.temp }}/yarg-audio-package
+          if-no-files-found: error

.gitignore

@@ -7,6 +7,7 @@
 /[Oo]bj/
 /[Bb]uild/
 /[Bb]uilds/
+/Native/YargAudio/build/
 /[Ll]ogs/
 /[Uu]ser[Ss]ettings/
 /UIElementsSchema/
@@ -41,6 +42,11 @@
 ExportedObj/
 .consulo/
 *.csproj
+!/Native/YargAudio/tests/GainIntegration/GainIntegration.csproj
+/Native/YargAudio/tests/GainIntegration/[Bb]in/
+/Native/YargAudio/tests/GainIntegration/[Oo]bj/
+/scripts/NativeBuild/[Bb]in/
+/scripts/NativeBuild/[Oo]bj/
 *.unityproj
 *.sln
 *.slnx
@@ -76,10 +82,15 @@ sysinfo.txt
 # Crashlytics generated file
 crashlytics-build.properties
 
-# Packed Addressables
-/[Aa]ssets/[Aa]ddressable[Aa]ssets[Dd]ata/*/*.bin*
-/[Aa]ssets/[Ss]ettings/[Aa]ddressable[Aa]ssets[Dd]ata/link.xml
-/[Aa]ssets/[Ss]ettings/[Aa]ddressable[Aa]ssets[Dd]ata/link.xml.meta
+# Addressables default ignores, before user customizations
+/ServerData
+/[Aa]ssets/StreamingAssets/aa*
+/[Aa]ssets/AddressableAssetsData/link.xml*
+/[Aa]ssets/Addressables_Temp*
+# By default, Addressables content builds will generate addressables_content_state.bin
+# files in platform-specific subfolders, for example:
+# /Assets/AddressableAssetsData/OSX/addressables_content_state.bin
+/[Aa]ssets/AddressableAssetsData/*/*.bin*
 
 # Temporary auto-generated Android Assets
 /[Aa]ssets/[Ss]treamingAssets/aa.meta
@@ -126,3 +137,14 @@ reload_lock~.meta
 
 # Unity crash dumps
 mono_crash.mem.*.blob
+
+# dotnet tool build output
+Tools/**/[Bb]in/
+Tools/**/[Oo]bj/
+
+qodana.yaml
+
+# VLC upstream checkouts and downloaded SDKs (managed by vlc/build.sh)
+/vlc/vlc-unity/
+/vlc/LibVLCSharp/
+/vlc/sdk/