Repository navigation
fix: ガラスのモデル置き換えを絞り、チャンク組み立て中は描画データを読む - #64
Merged
Merged
Conversation
…build - Only replace models of vanilla glass; other mods' StainedGlassBlock subclasses keep their own models (#41). - Keep quads without a cullface in the non-connected glass models. In doubles they are the inner face and follow the full-block rule. - Chunk-build paths (neighbour checks, inner faces, AO) read getBlockEntityRenderData instead of the live block entity. The render data now also carries the vertical axis.
Uses its own run directory (run-compat/, ignored by git) so mods added for compatibility checks never mix with the normal runClient setup.
Needed to run compatibility checks with mods that require 0.16.10 or newer. The minimum loader version in fabric.mod.json follows this value, so players need 0.16.14 or newer from beta.4.
runSceneCompat runs the scene capture with the mods in run-compat/mods. Block IDs come from SLABEE_SCENE_COMPAT_BLOCKS, and SLABEE_SCENE_ONLY=compat skips the catalog shots and the performance stages.
Each pair gets a crack_XX shot with breaking stage 9 on one full block and one double slab, plus a crack_XX_none twin from the same spot so the crack overlay can be diffed out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Yuru-Yurufu
changed the base branch from
fix/double-slab-light-refresh
to
main
October 24, 2026 16:57
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
描画互換性の調査メモ（AyaNote）にあった P1 の2点を直します。
1. ガラスのモデルの置き換え範囲（#41 の原因候補）
StainedGlassBlockを継承した他の MOD のガラスも Slabee のモデルに置き換えていた。そのため形や面の違うガラス（窓など）の見た目が崩れうる。minecraftのガラス（ガラス・色付きガラス16色・遮光ガラス）だけ。cullFaceのない面を捨てていたのをやめた。単体のハーフ・フルブロックでは必ず描き、ダブルハーフの内側の面は fix: 描画まわりのレビュー指摘（#7・#10・#11・#12）を修正 #62 と同じ「元のブロックどうしを並べたとき」の判定に従う。2. チャンクの組み立て中に Block Entity を直接読まない
shouldDrawSideの Mixin）を、getBlockEntityRenderDataで読むように統一した。DoubleSlabRenderDataに縦の向き（isX）を追加した。確認
#63 の上に積んでいます。
Generated by Claude Code
追加（2026-10-24）
./gradlew runCompat：他の MOD と一緒に試すための起動設定。run-compat/（Git 管理外）を使い、普段のrun/と混ざらない。fabric.mod.jsonの最低バージョンもこれに連動するので、beta.4 から遊ぶ人も 0.16.14 以上が必要（あやの判断で了承済み）。GameTest 19件成功。Generated by Claude Code