Skip to content

test: B2永続化spike（保存形式の検証とfixture） #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yuru-Yurufu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: B2永続化spike（保存形式の検証とfixture） #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions docs/roadmap/beta4.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,23 @@ gate, not an unanswered design decision. The spike is not the Stage 6 implementa
item; see the owner guide.
- Stage 1 remaining: the B2 persistence spike PR and the formal B4 performance
procedure (fixed controls, repetitions, JFR, versioned thresholds). Stage 2 follows.
- 2026-10-25: Opened the B2 persistence spike PR (`spike/b2-persistence`). The
codec lives in the gametest source set only (`gametest/persistence`), so the
shipped jar and Block Entities are unchanged apart from two read-only
`ModBlockMap` lookups. Findings to carry into Stage 6:
- `NbtHelper.toBlockState` silently returns air for unknown IDs and only logs bad
property values, so the codec validates the ID, `BlockTriple` family, and each
property before calling it; `Identifier.tryParse` avoids the exception on bad IDs.
- The schema is additive: legacy `positive_slab.id`/`negative_slab.id`/`axis` stay
and the current Block Entity reads the new format unchanged; a future
`version` falls back to those legacy fields.
- Besides `TYPE`/`FACING`/`SNOWY`/`DISTANCE`, the filter also drops
`WATERLOGGED` and `is_double` as container-owned. No current Slabee half owns a
property, so ownership was proven with vanilla leaves (`PERSISTENT`) through a
test-only catalog.
- Legacy reads now lose an invalid ID instead of substituting the default half;
the `dirt_path_slab` → `dirt_slab` rule stays outside the codec.
- Stage 1 then has only the B4 baseline PR left once the spike review passes.
- Dev-environment note: Sodium cannot load in the yarn dev runtime (`getColorIndex`
name clash in `BakedQuad`). Check it in a production-mapped client instead
(Loom 1.10+ `ClientProductionRunTask`).
Expand Down
Loading
Loading