Skip to content
Open
Show file tree
Hide file tree
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions packages/types/src/__tests__/provider-settings.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -166,3 +166,75 @@ describe("getApiProtocol", () => {
})
})
})

describe("openAiToolStrictMode", () => {
it("should be optional and absent by default", () => {
const result = providerSettingsSchemaDiscriminated.parse({
apiProvider: "openai",
openAiModelId: "test-model",
})
expect(result.apiProvider).toBe("openai")
if (result.apiProvider === "openai") {
expect(result.openAiToolStrictMode).toBeUndefined()
}
})

it("should accept true when provided", () => {
const result = providerSettingsSchemaDiscriminated.parse({
apiProvider: "openai",
openAiModelId: "test-model",
openAiToolStrictMode: true,
})
expect(result.apiProvider).toBe("openai")
if (result.apiProvider === "openai") {
expect(result.openAiToolStrictMode).toBe(true)
}
})

it("should accept false when provided", () => {
const result = providerSettingsSchemaDiscriminated.parse({
apiProvider: "openai",
openAiModelId: "test-model",
openAiToolStrictMode: false,
})
expect(result.apiProvider).toBe("openai")
if (result.apiProvider === "openai") {
expect(result.openAiToolStrictMode).toBe(false)
}
})

it("should not break existing profile deserialization when absent", () => {
const existingProfile = {
apiProvider: "openai" as const,
openAiBaseUrl: "https://api.example.com/v1",
openAiApiKey: "sk-test",
openAiModelId: "gpt-4",
openAiStreamingEnabled: true,
}
const result = providerSettingsSchemaDiscriminated.parse(existingProfile)
expect(result.apiProvider).toBe("openai")
if (result.apiProvider === "openai") {
expect(result.openAiModelId).toBe("gpt-4")
expect(result.openAiToolStrictMode).toBeUndefined()
}
})

it("should only exist on the openai (OpenAI Compatible) provider profile", () => {
const openAiResult = providerSettingsSchemaDiscriminated.parse({
apiProvider: "openai",
openAiToolStrictMode: true,
})
expect(openAiResult.apiProvider).toBe("openai")
if (openAiResult.apiProvider === "openai") {
expect(openAiResult.openAiToolStrictMode).toBe(true)
}

// Anthropic provider should not have this field
const anthropicResult = providerSettingsSchemaDiscriminated.parse({
apiProvider: "anthropic",
apiKey: "sk-test",
})
expect(anthropicResult.apiProvider).toBe("anthropic")
expect((anthropicResult as Record<string, unknown>).openAiToolStrictMode).toBeUndefined()
})
})
1 change: 1 addition & 0 deletions packages/types/src/provider-settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ const openAiSchema = baseProviderSettingsSchema.extend({
openAiStreamingEnabled: z.boolean().optional(),
openAiHostHeader: z.string().optional(), // Keep temporarily for backward compatibility during migration.
openAiHeaders: z.record(z.string(), z.string()).optional(),
openAiToolStrictMode: z.boolean().optional(), // Profile-scoped strict function-tool schema toggle for OpenAI Compatible provider. Absent = false (backward compatible).
})

const ollamaSchema = baseProviderSettingsSchema.extend({
Expand Down
59 changes: 0 additions & 59 deletions progress.txt

This file was deleted.

Loading