-
Notifications
You must be signed in to change notification settings - Fork 223
feature: unified-shell-resolution (3/4) #1135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
myk1yt
wants to merge
31
commits into
Zoo-Code-Org:main
Choose a base branch
from
myk1yt:pr/b06-terminal-lifecycle-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 25 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
09f6b6d
feat(shell): add shell settings contracts and cached-state UI binding
19a3dbf
fix(shell): add terminal shell settings translations to all 17 locales
ac0ed1b
fix(settings): restore mode-based cachedState sync reverted in B04 re…
a68ac23
feat(terminal): add unified shell resolution system (B05)
683b1e0
fix(task): remove BOM character from Task.ts causing invisible-chars …
4dc9610
fix(lint): update eslint-suppressions for B05 test files - add entrie…
28847b3
fix(terminal): use vscode provider for non-cmd shells in CommandEnvir…
0e63b22
fix(terminal): resolve B05 lifecycle and cross-platform CI failures
83e7e38
fix(terminal): pass profile shellArgs to VS Code terminal + restore m…
fae94c7
fix(terminal): guard illegal integration-ready self-transition + mock…
f851635
fix(terminal): respect static Terminal.getTerminalProfile() in comman…
b760a0d
fix(api): use optional call for getCommandEnvironmentService in setTe…
bc28103
test(e2e): raise shell-integration timeout to 30s in terminal-profile…
c08701f
fix(api): add runtime setShellIntegrationTimeout + apply it in termin…
9c3fd51
test(e2e): retry Terminal Profile suite on CI shell-integration flake
82d31f4
fix(terminal): use shell-integration-compatible profile in E2E test (…
9a5e2ae
fix(terminal): use shell-integration-safe --login arg in E2E test
60c5c77
fix(shell): mark settings dirty on shell selection change
35cc3dc
Merge branch 'pr/b04-shell-contracts-v2' into pr/b05-shell-resolution-v2
0f627a9
fix(ci): make RooTerminal lifecycle optional; ignore B06 scaffolding …
fcc3f09
fix(ci): add @types/shell-quote to dependencies
47e4687
fix(ci): resolve knip and check-types failures - exclude playwright, …
b2eef0b
fix(terminal): revert lifecycle/canReuse to required in RooTerminal i…
502e7df
chore: remove docs contamination and revert knip.json warn->off rules
bf2d780
chore: remove docs and scripts contamination
f033ccc
chore: remove temp file progress.txt
14f7617
feat: add local-ci-precheck skill for pre-push CI verification
2335da1
Merge branch 'main' into pr/b06-terminal-lifecycle-v2
myk1yt 1c9e578
test(e2e): add terminal lifecycle suite
57bbae1
fix(test): stop infinite fixture loop in terminal-lifecycle e2e (PR #…
065f8f6
fix(vscode-e2e): attach TaskAborted listener before triggering cancel…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Test the cross-profile input.
The Anthropic fixture does not include
openAiToolStrictMode. This test passes even if discriminated parsing starts to retain that OpenAI-only field. SupplyopenAiToolStrictMode: trueand assert the intended policy: rejection or removal.🤖 Prompt for AI Agents