Respect hide_from_feed for calendar-only events in feeds and Query Loops#82
Respect hide_from_feed for calendar-only events in feeds and Query Loops#82jbouganim wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
WalkthroughThis PR changes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
LGTM, will let @gin0115 have his say. |
Issue
Per-date Hide from feed was also removing the date from the calendar, even when Hide from calendar was off.
find_event_dates()ignored its context flags and always excluded both feed-hidden and calendar-hidden dates.Changes proposed in this Pull Request
$hide_from_calendarand$hide_from_feedinfind_event_dates()so each flag is applied only when its context parameter is true.get_event_dates_for_date( $date, true, false )) exclude calendar-hidden dates only.get_event_dates_for_date( $date, false, true )) exclude feed-hidden dates only.Testing instructions
Mentions #
@gin0115 @tommusrhodus
Summary by CodeRabbit