-
Notifications
You must be signed in to change notification settings - Fork 114
I add a bool property in inputs node #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HuiProject
wants to merge
9
commits into
aachman98:master
Choose a base branch
from
HuiProject:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a3ed6cd
input object's bool property : world origin
HuiProject c699669
input object's bool property : world origin
HuiProject e450a1f
nput object's bool property : world origin2
HuiProject becd542
input object's bool property : world origin 3
HuiProject 14329eb
Update helper.py
HuiProject 1314493
Update node_input.py
HuiProject 8224726
Update helper.py
HuiProject 0265fce
Update helper.py
HuiProject 956701e
Merge branch 'master' into master
HuiProject File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,13 +6,15 @@ | |
|
|
||
| class ScInputNode(ScNode): | ||
| in_name: StringProperty(default="Object", update=ScNode.update_value) | ||
| in_WorldOrigin: BoolProperty(default=False, update=ScNode.update_value) | ||
| # in_uv: BoolProperty(default=True, update=ScNode.update_value) | ||
| out_mesh: PointerProperty(type=bpy.types.Object) | ||
|
|
||
| def init(self, context): | ||
| self.node_executable = True | ||
| super().init(context) | ||
| self.inputs.new("ScNodeSocketString", "Name").init("in_name") | ||
| self.inputs.new("ScNodeSocketBool", "World Origin").init("in_WorldOrigin",True) | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Keep this property hidden by default because each input node has its own set of sockets visible by default (just to slightly increase UX) |
||
| # self.inputs.new("ScNodeSocketBool", "Generate UVs").init("in_uv") | ||
| self.outputs.new("ScNodeSocketObject", "Object") | ||
|
|
||
|
|
@@ -24,6 +26,7 @@ def error_condition(self): | |
| def pre_execute(self): | ||
| focus_on_object(self.out_mesh) | ||
| remove_object(self.out_mesh) | ||
|
|
||
|
|
||
| def post_execute(self): | ||
| out = {} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in_world_origin
(Just for consistency in variable names)