Add UTS tests for LiveObjects path-based API#2219
Draft
paddybyers wants to merge 3 commits into
Draft
Conversation
Translate portable UTS test specs from specification/uts/objects/ into working ably-js TypeScript tests covering PathObject, Instance, batch operations, LiveCounter/LiveMap CRDT internals, ObjectsPool sync state machine, RealtimeObject lifecycle, value types, and subscriptions. 19 test files: 14 unit (270 tests), 4 integration (15 tests), 1 proxy fault injection (5 tests). 1 test pending (LiveMap#clear() not yet implemented). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 task
Remove client-side port allocation (TOCTOU race) and let the proxy auto-assign free ports via OS. Read the assigned port from the session creation response. Update binary to v0.2.0 with new asset naming. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds parentReferences, PublicAPI::ObjectMessage, RTO24/25/26 tests; updates objectMessage/subscription assertions; removes batch API tests. 308 passing, 4 pending deviations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
specification/uts/objects/into 290 working ably-js TypeScript testsLiveMap#clear()not yet implemented in ably-js)Test plan
npx mocha --no-config --require tsx/cjs 'test/uts/objects/**/*.test.ts' --timeout 60000🤖 Generated with Claude Code