Skip to content

simplify condition for ABSL_INTERNAL_STD_FILESYSTEM_PATH_HASH_AVAILABLE #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
h-vetinari wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −4
Open

simplify condition for ABSL_INTERNAL_STD_FILESYSTEM_PATH_HASH_AVAILABLE #2066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions absl/hash/internal/hash.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,10 +683,6 @@ H AbslHashValue(H hash_state, std::basic_string_view<Char> str) {
}

#if defined(__cpp_lib_filesystem) && __cpp_lib_filesystem >= 201703L && \

@derekmauro derekmauro Jun 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of all the PRs I've accepted, I don't think there is any I regret accepting more than adding hashing for std::filesystem::path. I must have wasted an entire week on workarounds for platforms that do not have a file system. I think it is fine to remove ENVIRONMENT stuff, but please restore the __cpp_lib_filesystem guards. I don't feel like researching it, but I think there are platforms that do not define this because they do not have a file system.

@h-vetinari h-vetinari Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

(!defined(__ENVIRONMENT_IPHONE_OS_VERSION_MIN_REQUIRED__) || \
__ENVIRONMENT_IPHONE_OS_VERSION_MIN_REQUIRED__ >= 130000) && \
(!defined(__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__) || \
__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ >= 101500) && \
(!defined(__XTENSA__))

#define ABSL_INTERNAL_STD_FILESYSTEM_PATH_HASH_AVAILABLE 1
Expand Down