Skip to content

docs: warn against using &v[0] on empty vectors in MakeSpan #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Madhav1729 wants to merge 2 commits into from
+3 −0
Closed

docs: warn against using &v[0] on empty vectors in MakeSpan #2074

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7021f07
docs: warn against using &v[0] on empty vectors in MakeSpan
Madhav1729 Jun 10, 2026
aaee4d4
docs: condense MakeSpan warning per reviewer feedback
Madhav1729 Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions absl/types/span.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,6 +719,9 @@ constexpr bool operator>=(Span<T> a, const U& b) {
// return absl::MakeSpan(&array[0], num_elements_);
// }
//
// NOTE: To avoid undefined behavior if the container is empty, use `.data()`
// or pass the container directly instead of using `&v[0]` or `&v[v.size()]`.
//
template <int&... ExplicitArgumentBarrier, typename T>
constexpr Span<T> MakeSpan(T* absl_nullable ptr ABSL_ATTRIBUTE_LIFETIME_BOUND,
size_t size) noexcept {
Expand Down