Skip to content

CI fixes: Docker Login guard, DB/SALT fallback, NVD API mocking#69

Open
xMinhx wants to merge 2 commits into
accso:mainfrom
xMinhx:pr/ci-test-infra
Open

CI fixes: Docker Login guard, DB/SALT fallback, NVD API mocking#69
xMinhx wants to merge 2 commits into
accso:mainfrom
xMinhx:pr/ci-test-infra

Conversation

@xMinhx

@xMinhx xMinhx commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

Foundation PR that makes CI pass reliably on forks and when secrets are unavailable. All other PRs in this chain depend on this one.

Changes

  • Docker Login guard - skip login step when DOCKER_USER/DOCKER_KEY are empty (fork-friendly)
  • DB/SALT fallback - use env vars with shell defaults (secrets take priority, fallback values prevent crash-loop)
  • NVD API mocking - conftest.py patches requests for test isolation, moves CVE fetcher tests to fixtures, excludes nvd_integration marker by default. 66 tests now run in ~1s instead of timing out.

Notes

  • Depends on: nothing (base PR)
  • Required by: #security-hardening, #parser-fixes, #upstream-backports, #3tier-architecture

xMinhx added 2 commits June 27, 2026 15:45
- conftest.py patches requests.get + time.sleep in cve_fetcher module
- Skips mock for tests marked @pytest.mark.nvd_integration
- Moves test_cve_fetcher.py module-level code into fixtures
- pytest.ini excludes nvd_integration by default

66 tests now run in ~1s vs timing out at >120s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci / cd / devops enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant