Skip to content

Factorize BIDS path utils - #1462

Merged
cmadjar merged 21 commits into
aces:mainfrom
MaximeBICMTL:factorize-bids-path-utils
Aug 10, 2026
Merged

Factorize BIDS path utils#1462
cmadjar merged 21 commits into
aces:mainfrom
MaximeBICMTL:factorize-bids-path-utils

Conversation

@MaximeBICMTL

@MaximeBICMTL MaximeBICMTL commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Preparatory PR to merge the BIDS MEG importer in LORIS 30. This PR is built on top of the 29 branch but actually targets main.

Description

Factorize a few BIDS path-related utilities such as "parse BIDS entities from a file name" and "build a BIDS file name / path" in the loris_bids_utils.path module. Also add a few general utilities used in the process.

MaximeBICMTL and others added 8 commits June 23, 2026 11:54
* fix bids scans matching

* integration test and fix scans path bug

* add line that i forgot
* move the sourcing of the python environment up as this erase the PATH configuration when done at the end of the file

* Update comment for the python environment sourcingg
…#1455)

* remove update of session scan done field from the delete script now that the Scan_done field has been removed from the DB

* update MD file

---------

Co-authored-by: lorisadmin <lorisadmin@cbrain.mcgill.ca>
@github-actions github-actions Bot added Language: Perl Issue or PR related to the Perl codebase Language: Python Issue or PR related to the Python codebase Package: BIDS importer PR or issue related to the BIDS importer Package: Utilities PR or issue related to the LORIS-agnostic utilities Package: BIDS utilities PR or issue related to the BIDS utilities labels Jul 12, 2026
@MaximeBICMTL MaximeBICMTL added this to the 30.0.0 milestone Jul 16, 2026
@MaximeBICMTL
MaximeBICMTL force-pushed the factorize-bids-path-utils branch from 3cceed4 to dbb106c Compare July 16, 2026 09:52
hansfauer and others added 8 commits July 16, 2026 09:26
* Validate config-provided CenterID against the psc table in getPSC

* Validate config CenterID and finish removing MRI_alias from Perl

* shorten comment section

* address Nics comments: generate associated .md file for documentation changes in MRI.pm file. better validation strategy with PSCOB class rather than database check. Improved order of code for readability in tarchiveLoader.pl
* add dicom and bids importer documentation

* fix whoopsie
Co-authored-by: cmadjar <lorisadmin@cbrain.mcgill.ca>
kongtiaowang and others added 2 commits July 20, 2026 11:08
… generate Python config file. (aces#1477)

* fix old file name

* fix macos
* fix PosixPath error when running push to s3 script

* fix startswith s3:/ and return from remove empty directory if path does not exists on the file system

* check if directory exists before calling remove_empty_directory instead of inside the function
@MaximeBICMTL
MaximeBICMTL force-pushed the factorize-bids-path-utils branch from dceb8d3 to 8200f12 Compare July 21, 2026 05:25
@MaximeBICMTL
MaximeBICMTL requested a review from cmadjar July 21, 2026 05:35
@cmadjar
cmadjar merged commit 6157600 into aces:main Aug 10, 2026
6 of 7 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in LORIS MEG Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language: Perl Issue or PR related to the Perl codebase Language: Python Issue or PR related to the Python codebase Package: BIDS importer PR or issue related to the BIDS importer Package: BIDS utilities PR or issue related to the BIDS utilities Package: Utilities PR or issue related to the LORIS-agnostic utilities

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants