Skip to content

[genomic_browser] fixed missing rsID hyperlink in Genomic Browser #11043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fias06 wants to merge 1 commit into
base: 29.0-release
Choose a base branch
from
Open

[genomic_browser] fixed missing rsID hyperlink in Genomic Browser #11043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions modules/genomic_browser/jsx/tabs_content/snp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,22 @@ class SNP extends Component {
const url = `${this.props.baseURL}/${rowData.DCCID}/`;
reactElement = <td><a href={url}>{rowData.PSCID}</a></td>;
break;
case 'rsID':
const rsIdUrl = `https://www.ncbi.nlm.nih.gov/snp/${cell}`;
reactElement = (
<td>
<a href={rsIdUrl} target="_blank" rel="noopener noreferrer">
{cell}
</a>
</td>
);
break;
default:
reactElement = <td>{cell}</td>;
break;
}
return reactElement;
}

/**
* @return {DOMRect}
*/
Expand Down Expand Up @@ -218,7 +227,7 @@ class SNP extends Component {
},
{
label: t('rsID', {ns: 'genomic_browser'}),
show: false,
show: true,
filter: {
name: 'rsID',
type: 'text',
Expand Down
2 changes: 2 additions & 0 deletions modules/genomic_browser/php/models/snpdto.class.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ class SnpDTO implements DataInstance, SiteHaver
'PSCID' => $this->_PSCID,
'Sex' => $this->_Sex,
'Cohort' => $this->_Cohort,
'Date_of_Birth' => "",
'externalID' => $this->_externalID,
'Chromosome' => $this->_Chromosome,
'Strand' => $this->_Strand,
Expand All @@ -287,6 +288,7 @@ class SnpDTO implements DataInstance, SiteHaver
'Damaging' => $this->_Damaging,
'Genotype_Quality' => $this->_Genotype_Quality,
'Exonic_Function' => $this->_Exonic_Function,
'Genomic_Range' => "",
];
}

Expand Down
Loading