Skip to content

[ExternalLinks] Add missing French translations #11148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lapadulamichael wants to merge 2 commits into
base: 29.0-release
Choose a base branch
from
Open

[ExternalLinks] Add missing French translations #11148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3bd4c3
Adding missing translation
Aug 4, 2026
86bf3e6
Change LORIS to Loris
Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/dashboard/php/module.class.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ class Module extends \Module
foreach ($dashboard_links as $text => $url) {
$links[] = [
'url' => $url,
'label' => $text,
'label' => dgettext("ExternalLinks", $text),
'WindowName' => md5($url),
];
}
Expand Down
19 changes: 19 additions & 0 deletions raisinbread/locale/ExternalLinks.pot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
msgid ""
msgstr ""

"Project-Id-Version: LORIS 28\n"

@HachemJ HachemJ Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should change metadata header to LORIS 29 because this translation file is being introduced as part of LORIS 29.

"Report-Msgid-Bugs-To: https://github.com/aces/Loris/issues\n"
"POT-Creation-Date: 2025-04-08 14:37-0400\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
"Language: \n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"

msgid "Loris Website"
msgstr ""

msgid "GitHub"
msgstr ""
20 changes: 20 additions & 0 deletions raisinbread/locale/fr/LC_MESSAGES/ExternalLinks.po
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
msgid ""
msgstr ""

"Project-Id-Version: LORIS 28\n"

@HachemJ HachemJ Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should change metadata header to LORIS 29 because this translation file is being introduced as part of LORIS 29.

"Report-Msgid-Bugs-To: https://github.com/aces/Loris/issues\n"
"POT-Creation-Date: 2025-04-08 14:37-0400\n"
"PO-Revision-Date: 2026-06-11 14:37-0400\n"
"Last-Translator: Saagar Arya <saagar.arya@mcin.ca>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
"Language: fr\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Plural-Forms: nplurals=2; plural=(n > 1);\n"

msgid "Loris Website"
msgstr "Site web Loris"

msgid "GitHub"
msgstr "GitHub"
2 changes: 1 addition & 1 deletion src/Middleware/AnonymousPageDecorationMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface

$tpl_data['links'][] = array(
'url' => $url,
'label' => $label,
'label' => dgettext("ExternalLinks", $label),
'windowName' => $WindowName,
);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Middleware/UserPageDecorationMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ function ($a, $b) {

$tpl_data['links'][] = array(
'url' => $url,
'label' => $label,
'label' => dgettext("ExternalLinks", $label),
'windowName' => $WindowName,
);
}
Expand Down
Loading