Skip to content

Skip upgrade check on view command when exporting #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lisaSW merged 2 commits into from
Jun 17, 2026
Merged

Skip upgrade check on view command when exporting #104

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
035caf0
Skip upgrade check on view command when exporting
caffeinatedpixel Jun 3, 2026
17b9f35
Disabled the message when not passing output to a tty
pawelfloryan Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions cmd/view.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"database/sql"
"errors"
"fmt"
"os"

"github.com/activecm/rita/v5/config"
"github.com/activecm/rita/v5/database"
Expand Down Expand Up @@ -91,18 +92,18 @@ var ViewCommand = &cli.Command{
return err
}

// check for updates after running the command
if err := CheckForUpdate(cfg); err != nil {
return err
// check for updates after running the command, skip if using output flag
if !cCtx.Bool("stdout") {
if err := CheckForUpdate(cfg); err != nil {
return err
}
}

return nil
},
}

func runViewCmd(cfg *config.Config, dbName string, stdout bool, search string, limit int) error {
fmt.Printf("Viewing database: %s\n", dbName)

// connect to database
db, err := database.ConnectToDB(context.Background(), dbName, cfg, nil)
if err != nil {
Expand All @@ -120,6 +121,14 @@ func runViewCmd(cfg *config.Config, dbName string, stdout bool, search string, l

// if stdout was requested, get CSV output
if stdout {
outInfo, err := os.Stdout.Stat()
if err != nil {
return err
}
// display the message only when printing stdout to the terminal
if (outInfo.Mode() & os.ModeCharDevice) == os.ModeCharDevice {
fmt.Printf("Viewing database: %s\n", dbName)
}

// get CSV output
csvData, err := viewer.GetCSVOutput(db, minTimestamp, util.GetRelativeFirstSeenTimestamp(useCurrentTime, maxTimestamp), search, limit)
Expand Down