fix: code hardening to prevent bugs#171
Open
adbar wants to merge 4 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
- Coverage 97.92% 97.84% -0.08%
==========================================
Files 36 36
Lines 626 651 +25
==========================================
+ Hits 613 637 +24
- Misses 13 14 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
juanjoDiaz
approved these changes
Jun 17, 2026
juanjoDiaz
left a comment
juanjoDiaz
left a comment
Collaborator
There was a problem hiding this comment.
Lgtm!
Just couple of minor comments!
| SHORTER_GREEDY = {"bg", "et", "fi", "lv"} | ||
|
|
||
|
|
||
| def greedy_min_length(lang: str) -> int: |
Collaborator
There was a problem hiding this comment.
should this be a static method of the GreedyDictionaryLookupStrategy to keep the class-based approach?
Owner
Author
There was a problem hiding this comment.
I think module-level placement is easier here.
| str | None: The lemma for the token, or None if no lemma is found. | ||
|
|
||
| """ | ||
| if not any(hyphen in token for hyphen in HYPHENS): |
Collaborator
There was a problem hiding this comment.
Is this faster than the regex?
Owner
Author
There was a problem hiding this comment.
Yes, the most common case is that most tokens don't contain hyphens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.