Skip to content

feat(sdk): expose placement presentation validators - #2804

Merged
bokelley merged 1 commit into
mainfrom
krakow-v24
Sep 1, 2026
Merged

feat(sdk): expose placement presentation validators#2804
bokelley merged 1 commit into
mainfrom
krakow-v24

Conversation

@bokelley

@bokelley bokelley commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Closes #2800.

Summary

  • expose placement presentation validators from the package root and their types from supported entrypoints
  • document SSRF-safe, digest-pinned placement presentation validation
  • add CJS, ESM, and declaration-condition package export smoke coverage

Validation

  • env -u DATABASE_URL npm run ci:quick (16,971 fast tests, 413 slow tests, 30 ESLint-plugin tests, 18 renderer tests)
  • npm run ci:docs-check
  • three independent expert reviews with no remaining findings

Open workspace in Conductor

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — clean additive PR.

This PR exposes placement presentation validators (PlacementPresentationDocumentSchema/ReferenceSchema and their types) at the package root plus /schemas and /types, with accurate SSRF- and digest-pinned validation docs and thorough CJS/ESM/declaration-condition export smoke tests. All exports resolve to real generated symbols with verified same-instance identity; the witness-not-translator invariant and schemas-only policy guard both hold.

No blocking or medium findings. One Low nit only (changeset is patch but new public exports arguably warrant minor) — Low findings are omitted from the gate and do not block.

Decision-table walk: no critical/high findings (row 1 n/a); gated_paths false (row 2 n/a); high_risk false, no deletions (rows 3/5 n/a); no medium findings (rows 4/8 n/a); no no-auto-approve team match (row 7 n/a); no prior decision (row 6 n/a). Falls through to row 9 → approve.

Note: review_decision is REVIEW_REQUIRED, but since gated_paths is false this does not force escalation.

@bokelley
bokelley merged commit f6ada8e into main Sep 1, 2026
38 checks passed
@bokelley
bokelley deleted the krakow-v24 branch September 1, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(sdk): expose canonical placement-presentation validators

1 participant