Skip to content

test(tmproto): pin unknown-type and unknown-method wantErr substrings #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bokelley wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test(tmproto): pin unknown-type and unknown-method wantErr substrings #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tmproto/robustness_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ func TestArtifactRef_Validate(t *testing.T) {
}{
{"valid url", ArtifactRef{Type: ArtifactRefTypeURL, Value: "https://x"}, "", ""},
{"missing value", ArtifactRef{Type: ArtifactRefTypeURL}, "value", ""},
{"unknown type", ArtifactRef{Type: "starlink", Value: "x"}, "type", "starlink"},
{"unknown type", ArtifactRef{Type: "starlink", Value: "x"}, "not a known ArtifactRefType", "starlink"},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
Expand Down Expand Up @@ -270,7 +270,7 @@ func TestAssetAccess_Validate(t *testing.T) {
{"sa bad provider", AssetAccess{Method: AssetAccessMethodServiceAccount, Provider: "azure"}, "provider", "azure"},
{"signed ok", NewSignedURLAccess(), "", ""},
{"missing method", AssetAccess{}, "method: required", ""},
{"unknown method", AssetAccess{Method: "unknown"}, "method", "unknown"},
{"unknown method", AssetAccess{Method: "unknown"}, "not a known AssetAccessMethod", "unknown"},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
Expand Down
Loading