-
Notifications
You must be signed in to change notification settings - Fork 74
feat(reporting): add by_format delivery breakdown #6616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3342cf2
feat(reporting): add format delivery breakdown
bokelley 9e3fec8
test(reporting): tighten format breakdown contract
bokelley 9efb1d8
feat(reporting): sort contract for the format breakdown
bokelley 2e2bb5d
Merge remote-tracking branch 'origin/main' into adcp-reporting-gaps-3-2
bokelley 0e8b2b1
fix(reporting): document the format sort contract and refresh schema …
bokelley 426eca0
fix(reporting): align format sort_direction wording with the stack
bokelley 2698a48
Merge remote-tracking branch 'origin/main' into adcp-reporting-gaps-3-2
bokelley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "adcontextprotocol": minor | ||
| --- | ||
|
|
||
| Add capability-gated delivery breakdowns by canonical creative `format_kind` to `get_media_buy_delivery`, including explicit GET-only scope, `custom` aggregation, truncation disclosure, independent reconciliation from creative-level rows, and the full sort contract (`sort_direction` plus the `by_format_sorted_by`/`by_format_sort_direction` applied-sort echo with row-grain fallback and nulls-last semantics). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Medium:
sort_directionand the two MUST-return response echoes (by_format_sorted_by,by_format_sort_direction) aren't reflected in the task reference.docs/media-buy/task-reference/get_media_buy_delivery.mdxstill enumerates the accepted sort params as "optionallimitandsort_by" only, and its response section describesby_formatwithout the sort echo. The changeset advertises "the full sort contract," but an implementer reading the normative doc learns neither that sort is directional nor that two echo fields MUST be emitted wheneverby_formatis present. Schema and docs drift on a normative wire contract; documentsort_directionand the echo fields (including the fallback/nulls-last semantics) on the reference page.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 0e8b2b1: the task reference now documents
sort_direction(params table + Dimension Breakdowns paragraph with the row-grain fallback, direction MUST, and nulls-last rules) and theby_format_sorted_by/by_format_sort_directionecho in the by_format response section. Same commit merges main and refreshes the mcp-schema-analysis pins on the merged tree (the new sort fields moved the definition counts, which was the Canonical tests (1/4) failure).