Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/fix-storyboard-required-tools-or-gate.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"adcontextprotocol": patch
---

Fix 17 compliance storyboards that incorrectly included `get_adcp_capabilities` in `required_tools` alongside capability-specific tools. Because `required_tools` uses OR semantics, listing a universal tool made the storyboard-level gate trivially satisfied for every conformant agent — agents lacking the actual capability tool (e.g. `sync_accounts`, `build_creative`, `get_products`) would enter the storyboard and fail at the first capability-specific step instead of receiving a clean coverage-gap skip.

Affected storyboards: `billing_gate_dispatch`, `agent_notification_configs`, and 15 scenarios across the `media-buy` and `creative` protocol families.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ summary: "Verifies that a creative agent declaring bills_through_adcp: false rej
track: creative
introduced_in: "3.1"
required_tools:
- get_adcp_capabilities
- report_usage

narrative: |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ summary: "Verifies the 3.2 creative-agent canonical path: targetable supported_f
track: creative
introduced_in: "3.1"
required_tools:
- get_adcp_capabilities
- build_creative

narrative: |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ summary: "Verifies that build_creative evaluator pointers use the verifier allow
track: creative
introduced_in: "3.1"
required_tools:
- get_adcp_capabilities
- build_creative

narrative: |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ summary: "Verifies capability discovery, materialized localized sync, explicit d
track: creative
introduced_in: "3.2"
required_tools:
- get_adcp_capabilities
- sync_creatives
- list_creatives

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ requires_capability:
equals: buyer_selected

required_tools:
- get_adcp_capabilities
- sync_accounts
- list_accounts

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ requires_capability:
equals: seller_assigned

required_tools:
- get_adcp_capabilities
- sync_accounts
- list_accounts

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ requires_capability:
equals: seller_fixed

required_tools:
- get_adcp_capabilities
- sync_accounts
- list_accounts

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ requires:
- controller

required_tools:
- get_adcp_capabilities
- list_accounts
- create_media_buy
- get_media_buys
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ requires:
- controller

required_tools:
- get_adcp_capabilities
- list_accounts
- create_media_buy
- get_media_buys
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ requires:
- controller

required_tools:
- get_adcp_capabilities
- create_media_buy
- comply_test_controller

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ requires_capability:
contains: city

required_tools:
- get_adcp_capabilities
- get_products
- create_media_buy
- update_media_buy
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ requires_capability:
equals: true

required_tools:
- get_adcp_capabilities
- get_products
- comply_test_controller

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ requires_capability:
contains: FR-44

required_tools:
- get_adcp_capabilities
- get_products
- create_media_buy
- get_media_buys
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ requires_capability:
contains: FR-49

required_tools:
- get_adcp_capabilities
- get_products
- create_media_buy
- update_media_buy
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ track: media_buy
introduced_in: "3.2"

required_tools:
- get_adcp_capabilities
- get_products

narrative: |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ category: schema_validation
summary: "Validates the 3.2 agent-level capabilities.changed registration surface: advertised revision fencing, NO_AUTH rejection, and dry-run clear semantics."
track: core
required_tools:
- get_adcp_capabilities
- sync_agent_notification_configs

narrative: |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ category: error_compliance
summary: "Validates that account.supported_billing is declared and honored by sync_accounts, including out-of-set BILLING_NOT_SUPPORTED rejection, recovery-value consistency, and the distinct per-buyer-agent BILLING_NOT_PERMITTED_FOR_AGENT gate."
track: error_handling
required_tools:
- get_adcp_capabilities
- sync_accounts

narrative: |
Expand Down
Loading