Skip to content

Keep startup workflow binds recoverable #3172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
louis4li wants to merge 2 commits into
base: feature/integrate
Choose a base branch
from
Open

Keep startup workflow binds recoverable #3172

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c0f4c6
Keep startup workflow binds recoverable.
louis4li Aug 3, 2026
965b273
Merge feature/integrate into startup bind recovery.
louis4li Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/workflow/Aevatar.Workflow.Infrastructure/Workflows/FileBackedWorkflowCatalogPort.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,11 +279,11 @@ private async Task<long> WaitForCommittedBindAsync(
string actorId,
CancellationToken ct)
{
using var timeoutCts = CancellationTokenSource.CreateLinkedTokenSource(ct);
timeoutCts.CancelAfter(_options.BindCommitTimeout);
using var bindTimeoutCts = new CancellationTokenSource(_options.BindCommitTimeout);
using var readCts = CancellationTokenSource.CreateLinkedTokenSource(ct, bindTimeoutCts.Token);
try
{
await foreach (var observed in sink.ReadAllAsync(timeoutCts.Token))
await foreach (var observed in sink.ReadAllAsync(readCts.Token))
{
if (TryObserveCommittedBind(
observed,
Expand All @@ -296,7 +296,7 @@ private async Task<long> WaitForCommittedBindAsync(
}
}
}
catch (OperationCanceledException ex) when (!ct.IsCancellationRequested && timeoutCts.IsCancellationRequested)
catch (OperationCanceledException ex) when (bindTimeoutCts.IsCancellationRequested)
{
throw BindNotCommitted(definition, actorId, ex);
}
Expand Down
Loading