fix: bound unauthenticated rate-limiter memory - #501
Merged
Conversation
imran-siddique
marked this pull request as ready for review
August 11, 2026 19:01
Signed-off-by: Imran Siddique <imran.siddique@opaque.co>
imran-siddique
force-pushed
the
agent/bound-health-rate-limiter
branch
from
August 11, 2026 19:03
2633f37 to
a294bd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bound the state retained by the unauthenticated
/healthand/readyzper-IP rate limiter. Expired client windows are reclaimed, and at most 10,000 active source addresses are tracked; new addresses fail closed with the existing 429 response when capacity is reached.Root cause
The limiter pruned timestamps within each requesting IP's list but never removed IP keys from its process-lifetime dictionary. Source-address churn could therefore grow memory without bound even though each individual address stayed within its request budget.
Validation
git diff --check: cleanDocumentation