Fix: Mark JSON encoding flag constants as unsigned to avoid signed overflow issues - #754
Open
maruixin-kls wants to merge 1 commit into
Open
maruixin-kls wants to merge 1 commit into
maruixin-kls wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #694.
Problem:
The JSON encoding flag constants (e.g., JSON_COMPACT, JSON_SORT_KEYS) were defined as signed integers by default. When these flags are combined or used in bitwise operations, it can lead to undefined behavior or compiler warnings regarding signed overflow, especially on platforms where int is 32-bit.
Solution:
Added the u suffix to all hexadecimal flag constants in src/jansson.h to explicitly define them as unsigned int.
Changes:
Modified JSON_MAX_INDENT, JSON_COMPACT, JSON_ENSURE_ASCII, etc., to use the u suffix.
Closes #694.