Repository navigation
Reject dependency aliases that share build artifact paths - #29643
Closed
mohammadfawaz wants to merge 2 commits into
Closed
mohammadfawaz wants to merge 2 commits into
mohammadfawaz wants to merge 2 commits into
Conversation
mohammadfawaz
added
🐛 bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #29639. The implementation and regression coverage are included in that combined PR. Review the changes there.
Dependency names such as
victimandvictim.aleowere distinct graph nodes but used the same build directory and bytecode path. A transitive dependency could occupy the primary program's output path before the primary program was written.Reject distinct dependency names that have the same name after removal of the
.aleosuffix. The check runs during graph construction, before build artifacts are written. Repeated dependencies with the same name retain their existing compatibility checks.Addresses VERIA-39.
Original finding: https://veria.dev/dashboard/findings/YjsTrJIAH6lHK6d-3nvI7