Repository navigation
Reject unsafe package symlinks and lock paths - #29645
Closed
mohammadfawaz wants to merge 3 commits into
Closed
mohammadfawaz wants to merge 3 commits into
mohammadfawaz wants to merge 3 commits into
Conversation
mohammadfawaz
added
🐛 bug
mohammadfawaz
force-pushed
the
codex/fix-veria-38-package-symlinks
branch
from
September 28, 2026 15:21
4dabea9 to
97bd304
Compare
mohammadfawaz
changed the base branch from
codex/pin-network-bytecode
to
master
September 28, 2026 15:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #29639. The implementation and regression coverage are included in that combined PR. Review the changes there.
Package loading could follow committed symlinks while reading source files or updating
leo.lock. A malformed locked commit could also select a path outside the Git checkout cache.Reject unsafe source entries, source and test directories, manifest files, lock files, and Git checkout links before using them. Check locked commit strings before constructing paths. Replace lock files through a new temporary file and rename, while retaining the existing file permissions. Source discovery and compiler/LSP directory walks use the same link policy.
Explicit local package paths and in-memory sources remain supported. These checks address committed filesystem entries; they do not provide race-free reads against a process that can change the filesystem concurrently.
Addresses VERIA-38.
Original finding: https://veria.dev/dashboard/findings/n5AWPUXjfpayqyKgkdW7Y