Skip to content

Constrain local dependency names and build output paths - #29648

Closed
mohammadfawaz wants to merge 2 commits into
masterfrom
codex/fix-veria-44-local-dependency-names
Closed

mohammadfawaz wants to merge 2 commits into
masterfrom
codex/fix-veria-44-local-dependency-names

Conversation

@mohammadfawaz

@mohammadfawaz mohammadfawaz commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Superseded by #29639. The implementation and regression coverage are included in that combined PR. Review the changes there.

Local dependency names could contain paths and cause build output to replace files outside the build directory. Existing symlinks in the build tree could also redirect output.

Validate primary and dependency names before constructing artifact paths, and require local bytecode to declare the requested program identity. Preserve valid Aleo program names and existing Leo library names. Reject symlinks and nonregular entries in an existing build tree before writing artifacts.

Addresses VERIA-44. This checks existing filesystem entries; it does not provide isolation against concurrent filesystem changes.

Original finding: https://veria.dev/dashboard/findings/Kryvats8XWjkLg0og7SHM

@mohammadfawaz mohammadfawaz added 🐛 bug Something isn't working 🧱 Core Compiler Anything related to the core compiler including parsing, analysis, transforms, codegen, etc. labels Sep 28, 2026
@mohammadfawaz mohammadfawaz self-assigned this Sep 28, 2026
@mohammadfawaz mohammadfawaz added the 🖥️ CLI Anything related to the Leo CLI. label Sep 28, 2026
@mohammadfawaz
mohammadfawaz force-pushed the codex/fix-veria-44-local-dependency-names branch from ca7509c to fab0e33 Compare September 28, 2026 15:12
@mohammadfawaz
mohammadfawaz changed the base branch from codex/fix-dependency-name-traversal to master September 28, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working 🖥️ CLI Anything related to the Leo CLI. 🧱 Core Compiler Anything related to the core compiler including parsing, analysis, transforms, codegen, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant