[FIX] Use Cpp20 Git tag for LEMON#2129
Open
philippremy wants to merge 1 commit into
Open
Conversation
Fixes a small issue where CMake/Git is unable to checkout a specific commit. Use the Cpp20 release/tag specifically.
Contributor
|
Lemon is currently under maintenance and a new version should be available soon with reduced warnings for c++20 and modern cmake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small fix which I regularly encounter when rebuilding with dependencies:
CMake is unable to checkout this specific commit and there is a proper release/tag for C++20 support. This is a regression introduced by specifying
GIT_SHALLOWinExternalProject_Add, which removes the option to specify a commit hash inGIT_TAG(see the docs).Commit alicevision/lemon@8885b9a will be missing though... so either we don't need this or we should create a new release/tag/branch with this specific commit over at LEMON.