fix: prevent oversized entries from retaining buffers - #435
Open
G4RASU wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cacheShard.setandcacheShard.appendbuild the wrapped entry inentryBufferbefore pushing it into the shard'sentriesqueue.When the final entry is larger than the shard's maximum capacity,
BytesQueue.Pusheventually rejects it. However, the entry has already causedentryBufferto grow, and the failed push path may also evict existing entries before returning the error.This causes unnecessary memory retention and can remove valid cached entries even though the new entry cannot be stored.
This change adds a non-mutating
BytesQueue.CanFitcheck before usingentryBuffer:Setchecks the encoded entry size before wrapping it.Appendchecks the final size of the existing entry plus the new data.ErrEntryTooBigimmediately.Adds regression tests covering oversized
SetandAppendoperations, verifying that neitherentryBuffernor the queue grows and that existing entries are preserved.go test ./...passes.