docs: fix typos in comments, XML docs and messages - #63
Open
Avicennasis wants to merge 1 commit into
Open
Avicennasis wants to merge 1 commit into
Avicennasis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix 15 typos across 9 files, each verified against current
main. Almost all are XML doc comments / inline comments; two touch message strings (called out below).Comments and XML docs
<param name="request">Data send to dependency</param>->Data sent to dependencyThe policy is build and cached at first usage->is built and cached(1x) andThe policy is build at first usage->is built at first usage(2x)Default timeout strategy used by Polly.TimeouPolicy->Polly.TimeoutPolicyensure that object that not supports NRT is still valid->that does not support NRTValidates if instance of object is is not braking NRT rules for objects that not enables it.->is not breaking NRT rules for objects that do not enable it.(doubledis,braking->breaking)we might not be able o wrote to response, so whe just log this fact->not be able to write to response, so we just log this factvalidation handling support of requets->requestsCustom validation confgiruation->Custom validation configuration<param name="services">Service collections</param>->Service collection(2x; the parameter is a singleIServiceCollection)Tires to parse enum value->Tries to parse enum valueStrings - please review carefully
$"Invalid currency! {c1} is different than {{c2}}"->{c2}. The doubled braces escape the interpolation, so this exception currently prints the literal text{c2}instead of the second currency. The identical message 30 lines below (inCompare) already uses{c2}.$"Multiple handler for query ..."->Multiple handlers for query ...(exception message)This rule will be not applied->This rule will not be applied(word order only; the{FilterKey}/{FilterValue}/{FilterType}placeholders are untouched)Data = "Custom resposne data"->"Custom response data"I grepped the repo for each of these strings - nothing else references them and no test asserts on them.
No versions or CHANGELOGs were bumped, since nothing here changes package behaviour apart from the
Moneyexception text; happy to add those if you would prefer.Also spotted but not touched, since it was outside the scope I was working from:
src/Allegro.Extensions.AspNetCore/README.mdline 128 has the sameerror resposnetypo. Say the word and I will include it.