Validate client edict bounds/free state in SV_DropClient_PreHook - #1160
Merged
psychonic merged 2 commits intoSep 16, 2026
Merged
Conversation
GET_PLAYER_POINTER was being called on the raw edict without confirming it was valid.
psychonic
requested changes
Sep 16, 2026
psychonic
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET_PLAYER_POINTER was being called on the raw edict without confirming it was valid.
This would occasionally cause an "Bad entity in IndexOfEdict()" crash after a client disconnected unexpectedly (e.g. a timeout or other network drop).
I extracted a stacktrace from one of these crashes which helped point to this being the cause
I wasn't able to reliably repro this, although it happened relatively frequently, but I have not seen another crash of this type since applying this patch.