Fix SQL_IsNull() returning 0 for NULL columns in threaded queries - #1166
Merged
psychonic merged 1 commit intoSep 20, 2026
Merged
Conversation
Threaded query results are copied into an AtomicResult, which stored NULL cells as empty strings, so IsNull() could never report NULL. Store NULL cells as empty slots and make GetString() return NULL for them. Fixes alliedmodders#1165
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1165.
Threaded query results are copied into an
AtomicResultinCopyFrom(), which turned NULL cells into empty strings, soIsNull()could never return true. This stores NULL cells as empty slots instead, andGetString()returnsNULLfor them. Same change inmysqlxandsqlite.Tested with the released 1.10.0.5481 modules as baseline vs. a build with this change, on both MySQL and SQLite, using the sqlx and dbi natives with regular and threaded queries. The only difference is the threaded NULL cells now reporting
IsNull() == 1. All other output and the error logs are identical.