fix(core): keep allure serve alive when historyPath is configured - #861
Open
svasenkov wants to merge 1 commit into
Open
fix(core): keep allure serve alive when historyPath is configured#861svasenkov wants to merge 1 commit into
svasenkov wants to merge 1 commit into
Conversation
AllureLocalHistory.appendHistory left FileHandle write streams ref'd after pipeline completed. Closing the handle then made Node exit before report.done() and serve resolved, which matched the silent allure serve exit in allure-framework#827. Finish and destroy the write stream before closing the file handle, and add regression coverage for the stream lifecycle and serve integration. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allure servesilently exiting after report generation whenhistoryPathis set inallurerc.mjs(Fixes [CLI]allure servesilently exits without starting the server whenhistoryPathis set #827).AllureLocalHistory.appendHistory()piped into aFileHandlewrite stream withautoClose: falseand closed the handle before the stream was destroyed. On Node.js 20+ this leaves a pending promise and can terminate the process beforeservestarts.Test plan
packages/corehistory tests, including a standalone Node subprocess reproducing the FileHandle stream lifecyclepackages/cliintegration test:allure serve allure-resultswithhistoryPathprintsAllure is running on http://localhost:…and keeps runningallure@3.14.3flow (history written, process used to exit with code 0 before server URL)Made with Cursor