fix(core): replace stale entry in RetrySubstore.upsert instead of pushing a duplicate (fixes #896) - #897
Open
meganemura wants to merge 1 commit into
Conversation
…hing a duplicate Re-upserting the same test result id appended a second array entry instead of replacing the first, so retriesByTr could list a test as its own retry. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
RetrySubstore.upsert(packages/core/src/store/retrySubstore.ts) always pushed the incomingTestResultonto theretryHasharray without checking whether an entry with the sameidalready existed. When the same result id was upserted twice (see #896 for how this happens and a self-contained repro), the array ended up with two entries sharing oneid— one stale, one fresh — andretriesByTrreported the test as having a retry of itself.DefaultAllureStorealready treats a re-visit of the same id as an update, not a new entry:#testResults.set(testResult.id, testResult)is aMap, so the same key replaces the old value. This PR makesRetrySubstore.upsertfollow the same rule — if an entry with the sameidis already in the array, replace it in place instead of pushing a duplicate.Added a regression test that upserts the same id twice with a newer
startand assertsretriesByTrno longer returns a duplicate.Fixes #896
Checklist