Show passed quality gate rules in the report (fixes #806) - #928
Open
d-braun wants to merge 4 commits into
Open
Conversation
Resolve the conflict in ReportQualityGateResults: keep the upstream rename of
AwesomeQualityGateValidationResult to ReportQualityGateValidationResult and the
useI18n("ui") hook the passed-rule "Success" header needs.
Konflikte in der Quality-Gate-Logik aufgelöst: - QualityGateRule: `successMessage` uebernommen und auf den neuen generischen `actual: K` aus main umgestellt - allTestsContainEnv: numerisches `actual` per String() formatiert, successMessage beibehalten - Tests: beide neuen describe-Bloecke (success messages, metric rules) vereinigt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes #806.
The Quality Gate tab only ever showed failed rules. A run that passed every rule rendered
"No quality gate results available", which reads as if no quality gate was configured at all, and a
run with one failing rule out of many hid the rules that were validated successfully. Report readers
had no way to see which quality criteria were actually evaluated.
QualityGate.validate()dropped passed rules with an earlycontinue, so they never reached thestore and never made it into
widgets/quality-gate.json. This changes the validation to report everyevaluated rule and makes the report render passed and failed rules side by side.
Core (
@allurereport/core,@allurereport/plugin-api)QualityGate.validate()now returns every evaluated rule, each carrying itssuccessflag.fastFailstill triggers on failures only.filterFailedQualityGateResults()helper.stringifyQualityGateResults()andconvertQualityGateResultsToTestErrors()filter internally, so terminal output and test errors keepreporting failures only.
QualityGateRulegained an optionalsuccessMessage. All built-in rules provide one; custom ruleswithout it fall back to a generic message.
CLI (
allure)allure quality-gateandallure runis now derived from the number of failedrules instead of the length of the result list. Passed rules are sent to the report but are not
printed to the terminal.
Report (
@allurereport/web-awesome)TrErroraccepts an optionaltitleso the block header can read "Success" instead of "Error".something actually failed, while the tab itself lists every evaluated rule.
ui.successkey to all 21 locales.No changes to the shape of
widgets/quality-gate.jsonbeyond the additional entries: passed rulesappear as regular entries with
"success": true, so existing consumers keep working.Checklist