Skip to content

Updating snippet to use coil3 artifact #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wardlauren wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Updating snippet to use coil3 artifact #1030

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
446ad5d
Updating snippet to use coil3 artifact
wardlauren Aug 13, 2026
62c8059
Merge branch 'main' into coil-branch
riggaroo Aug 14, 2026
d624a8f
Addressing comments
wardlauren Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions compose/snippets/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,8 @@ dependencies {
implementation(libs.accompanist.permissions)

implementation(libs.coil.kt.compose)
implementation(libs.coil3.compose)
implementation(libs.coil3.network.okhttp)
implementation(libs.androidx.activity.compose)
implementation(libs.androidx.appcompat)
implementation(libs.androidx.core.ktx)
Expand Down
2 changes: 1 addition & 1 deletion compose/snippets/src/main/java/com/example/compose/snippets/images/LoadingImagesSnippets.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import androidx.compose.runtime.Composable
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.tooling.preview.Preview
import coil.compose.AsyncImage
import coil3.compose.AsyncImage

@yrezgui yrezgui Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why aren't we updating all the imports in the compose module to reference coil3?

@wardlauren wardlauren Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I've updated all the imports in the Compose module now to reference coil3.

import com.bumptech.glide.integration.compose.ExperimentalGlideComposeApi
import com.bumptech.glide.integration.compose.GlideImage
import com.example.compose.snippets.R
Expand Down
5 changes: 5 additions & 0 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ androidx-work-runtime = "2.11.2"
androidxHiltNavigationCompose = "1.4.0"
appcompat = "1.7.1"
camera-camera2 = "1.6.1"
# Coil 2
coil = "2.7.0"
Comment on lines +44 to 45

@riggaroo riggaroo Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to remove this

# Coil 3
coil3 = "3.5.0"
# @keep
compileSdk = "37"
compose-latest = "1.12.0"
Expand Down Expand Up @@ -284,6 +287,8 @@ appcompat = { module = "androidx.appcompat:appcompat", version.ref = "appcompat"
billing = { module = "com.android.billingclient:billing-ktx", version.ref = "playbilling" }
camera-camera2 = { module = "androidx.camera:camera-camera2", version.ref = "camera-camera2" }
coil-kt-compose = { module = "io.coil-kt:coil-compose", version.ref = "coil" }
coil3-compose = { module = "io.coil-kt.coil3:coil-compose", version.ref = "coil3" }
coil3-network-okhttp = { module = "io.coil-kt.coil3:coil-network-okhttp", version.ref = "coil3" }
compose-foundation = { module = "androidx.wear.compose:compose-foundation", version.ref = "wearComposeFoundation" }
compose-ui-tooling = { module = "androidx.wear.compose:compose-ui-tooling", version.ref = "composeUiTooling" }
crossdeviceprompt = { module = "com.google.android.play:crossdeviceprompt", version.ref = "crossdeviceprompt" }
Expand Down
2 changes: 2 additions & 0 deletions tv/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ dependencies {
implementation(libs.androidx.fragment.ktx)
implementation(libs.androidx.work.runtime.ktx)
implementation(libs.coil.kt.compose)
implementation(libs.coil3.compose)

@yrezgui yrezgui Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding these libraries in this module? The imports are still referecing coil2

@wardlauren wardlauren Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the library from this module.

@pflammertsma pflammertsma Aug 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused why we're adding coil3 as a dependency without changing the import; see the usages.

@pflammertsma pflammertsma Aug 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please either remove the implementation or add the coil3 import.

@wardlauren wardlauren Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the library from this module.

implementation(libs.coil3.network.okhttp)
implementation(libs.androidx.media3.common)
implementation(libs.androidx.media3.exoplayer)
implementation(libs.androidx.media3.ui)
Expand Down
Loading