Migrate performance snippets - #1055
Conversation
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
3e6e001 to
8f5c282
Compare
|
Thanks Peng, could you rename the title of the PR to something like Migrate performance snippets? Also feel free to remove any comments in the PR description if it refers to intermediate states of the PR and is not reflected in the final code (e.g. mentions of System.gc() can be removed now). I've also added our Performance DRE, Ajesh, for review on the PR too. |
Got it, since the final diff wouldn't show those intermediary changes and it will be confusing to reviewer. Let me remove. |
| // Disable unused AGP features | ||
| viewBinding = true | ||
|
|
||
| buildConfig = true |
There was a problem hiding this comment.
actually instead of enabling this in the build file, can we handle this by declaring a mock object in the AnalysisOptimization file?
private object BuildConfig {
const val DEBUG = true
}
Because I think enabling this property can have build time implications for everyone using the snippets repo. And in the AGP 8.0 Release Notes, it looks like buildConfig is false by default to eliminate this compilation overhead.
This PR aims to add following hard-coded snippets from DAC to repo:
(3 snippets) Analysis optimization
(2 snippets) Best practices
Summary: