Nest CameraX snippets under :camera :camerax - #1077
Open
barbaralaw wants to merge 5 commits into
Open
Conversation
This leaves room for sibling camera APIs (such as Camera2) under the same :camera parent instead of top-level :camerax.
Contributor
|
Thanks for the pull request but we're not looking at expanding the camera snippets beyond camerax at the moment. I'm closing it for now |
Contributor
|
I should look more at my emails (didn't know the context), sorry for the confusion @barbaralaw 🙏 |
kkuan2011
reviewed
Sep 10, 2026
kkuan2011
reviewed
Sep 11, 2026
kkuan2011
left a comment
Contributor
There was a problem hiding this comment.
Looks good after comments addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:cameraxGradle module to:cameraand nests camerax files as a sub-folder package within it so camera APIs can share a parent module instead of living at the repo root.Test plan
./gradlew :camera:camerax:compileDebugKotlin./gradlew :camera:camerax:buildBuild Allstill succeeds on this path:cameraxmodule path