Skip to content

Nest CameraX snippets under :camera :camerax - #1077

Open
barbaralaw wants to merge 5 commits into
android:mainfrom
StellarElements:nest-camerax-under-camera
Open

Nest CameraX snippets under :camera :camerax#1077
barbaralaw wants to merge 5 commits into
android:mainfrom
StellarElements:nest-camerax-under-camera

Conversation

@barbaralaw

@barbaralaw barbaralaw commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Renames the existing :camerax Gradle module to :camera and nests camerax files as a sub-folder package within it so camera APIs can share a parent module instead of living at the repo root.
  • Existing region tags within camerax files renamed to specify new package path

Test plan

  • ./gradlew :camera:camerax:compileDebugKotlin
  • ./gradlew :camera:camerax:build
  • Confirm CI Build All still succeeds on this path
  • Confirm no remaining references to the old :camerax module path

This leaves room for sibling camera APIs (such as Camera2) under the same :camera parent instead of top-level :camerax.
@barbaralaw
barbaralaw requested review from a team as code owners September 8, 2026 22:05
@snippet-bot

snippet-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 35 region tags.
You are about to delete 35 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@yrezgui

yrezgui commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Thanks for the pull request but we're not looking at expanding the camera snippets beyond camerax at the moment. I'm closing it for now

@yrezgui yrezgui closed this Sep 10, 2026
@yrezgui yrezgui reopened this Sep 10, 2026
@yrezgui

yrezgui commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

I should look more at my emails (didn't know the context), sorry for the confusion @barbaralaw 🙏

Comment thread settings.gradle.kts Outdated

@kkuan2011 kkuan2011 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after comments addressed

Comment thread camera/build.gradle.kts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants