Serialize audio capability callbacks on receiver handler - #3388
Draft
ajay-jg wants to merge 2 commits into
Draft
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3386
Why
On some Android TV/STB devices,
AudioDeviceCallbackcan be invoked from a looper-less OEM thread such asAudioMonitorHdmiThread.AudioCapabilitiesReceivercurrently evaluates capabilities and notifies its listener directly from that callback.This can call
DefaultAudioSink.onAudioCapabilitiesChanged()off the playback looper and crash with:IllegalStateException: Current looper (null) is not the playback looper (main)What changed
Testing
./gradlew :lib-exoplayer:testDebugUnitTest --tests androidx.media3.exoplayer.audio.AudioCapabilitiesReceiverWrongThreadTest --no-daemonThe test failed before the fix with the callback thread name and passed after the fix with the receiver handler thread.