Skip to content

fix(ng-dev): validate nvmrc-sourced Node.js version before fetch #3738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josephperrott merged 2 commits into from
Jun 8, 2026
+6 −0
Merged

fix(ng-dev): validate nvmrc-sourced Node.js version before fetch #3738

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deb0f49
fix(ng-dev): validate nvmrc-sourced Node.js version before fetch
adilburaksen Jun 4, 2026
34d6c76
fixup! fix(ng-dev): validate nvmrc-sourced Node.js version before fetch
josephperrott Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ng-dev/misc/sync-module-bazel/sync-module-bazel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,10 @@ async function processNodeToolchainArgs(
return args;
}

if (!semver.valid(effectiveVersion)) {
throw new Error(`Invalid Node.js version: ${effectiveVersion}`);
}
Comment thread
josephperrott marked this conversation as resolved.
Outdated

Log.info(`Resolving Node.js repositories for v${effectiveVersion}...`);
const repositories = await getNodeJsRepositories(effectiveVersion);
const lines = repositories.map(({filename, sha, type}) => {
Expand Down