piaf.opam: eio and multipart_form are dependencies

[edwintorok]

'opam pin add --dev piaf' fails without them.

Unfortunately this doesn't quite work yet because multipart_form usage fails to build:

#=== ERROR while compiling piaf.0.1.0 =========================================#
# context     2.1.2 | linux/x86_64 | ocaml-base-compiler.5.0.0 | pinned(git+https://github.com/anmonteiro/piaf.git#ffb6f09f)
# path        ~/.opam/5.0.0/.opam-switch/build/piaf.0.1.0
# command     ~/.opam/opam-init/hooks/sandbox.sh build dune build -p piaf -j 8
# exit-code   1
# env-file    ~/.opam/log/piaf-3002419-684c18.env
# output-file ~/.opam/log/piaf-3002419-684c18.out
### output ###
# [...]
# Error: This function has type
#          emitters:'a Multipart_form.emitters ->
#          Multipart_form.Content_type.t -> 'a Multipart_form.t Angstrom.t
#        It is applied to too many arguments; maybe you forgot a `;'.
# (cd _build/default && /home/edwin/.opam/5.0.0/bin/ocamlc.opt -w -40 -g -bin-annot -I multipart/.multipart.objs/byte -I /home/edwin/.opam/5.0.0/lib/angstrom -I /home/edwin/.opam/5.0.0/lib/base64 -I /home/edwin/.opam/5.0.0/lib/base64/rfc2045 -I /home/edwin/.opam/5.0.0/lib/bigarray-overlap -I /home/edwin/.opam/5.0.0/lib/bigstringaf -I /home/edwin/.opam/5.0.0/lib/bytes -I /home/edwin/.opam/5.0.0/[...]
# File "multipart/multipart.ml", line 280, characters 14-35:
# 280 |     AU.parse (Multipart_form.parser ~max_chunk_size ~emitters content_type)
#                     ^^^^^^^^^^^^^^^^^^^^^
# Error: This function has type
#          emitters:'a Multipart_form.emitters ->
#          Multipart_form.Content_type.t -> 'a Multipart_form.t Angstrom.t
#        It is applied to too many arguments; maybe you forgot a `;'.```

[edwintorok]

Would be useful to know which version of 'multipart_form' piaf expects

[anmonteiro]

I need to do a better job documenting the dependencies issue for this repo. It works real well with nix, but that's not an expectation I can have for most users.

• multipart form: https://github.com/anmonteiro/multipart_form/tree/fork
• httpaf: https://github.com/anmonteiro/httpaf/tree/fork
• websocketaf: https://github.com/anmonteiro/websocketaf/tree/fork
• (unreleased) gluten (+ gluten-eio): https://github.com/anmonteiro/gluten
• probably needs eio 0.8 too ([new release] eio_main, eio_luv, eio_linux and eio (0.8) ocaml/opam-repository#23208)

[edwintorok]

Thanks. I think 'opam' supports something called 'pin-depends' which would allow to specify exactly what packages a user needs to pin when they pin your repo, although I have never used it myself yet: https://opam.ocaml.org/doc/Manual.html

[anmonteiro]

Those would be great things to add for the next opam user trying to install this project. Thanks for the feedback!

[anmonteiro]

CI now runs an OPAM build here which guarantees piaf can be used with opam #167