fix: resolve optional chain lint warnings#1905
Closed
meet-student wants to merge 5 commits into
Closed
Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughPR 统一应用可选链操作符简化多处空值检查，显式转换 Token 字体值为 Number 确保类型安全，改进流式聊天处理的错误处理策略（从记录改为静默），并扩展测试基础设施以支持持续挂起请求和中止场景测试。 Changes可选链、数值转换与流式处理改进
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors several files to use optional chaining for more concise null and undefined checks. The reviewer suggested further simplifying a condition in custom-provider-width-ui.tsx by removing redundant optional chaining in a logical OR expression where the object's existence is already verified by the preceding check.
Bundle ReportBundle size has no change ✅ |
meet-student
force-pushed
the
codex/fix-optional-chain-lint
branch
from
0c2e025 to
2046652
Compare
17 tasks
meet-student
force-pushed
the
codex/fix-optional-chain-lint
branch
2 times, most recently
from
348a84a to
5607322
Compare
meet-student
changed the title
meet-student
force-pushed
the
codex/fix-optional-chain-lint
branch
from
5607322 to
d0395b0
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/x/components/attachments/FileList/Progress.tsx (1)
17-17: 💤 Low value简化数值转换（避免不必要的
Number(...)）
token.fontSizeHeading2在该仓库主题类型中为number（packages/x/components/theme/interface/maps/font.ts），且在其他样式使用处也直接作为数值使用（如packages/x/components/attachments/style/index.ts、packages/x/.dumi/pages/index/components/DesignGuide.tsx），因此这里的Number(token.fontSizeHeading2) * 2属于冗余。antd的Progress（type="circle"）的size支持number，当前传入的数值类型是匹配的；除非能证明运行时会出现undefined，不需要为了防御性再补NaNfallback。建议将
size={Number(token.fontSizeHeading2) * 2}简化为size={token.fontSizeHeading2 * 2}以保持一致性。🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/x/components/attachments/FileList/Progress.tsx` at line 17, The expression size={Number(token.fontSizeHeading2) * 2} is redundant because token.fontSizeHeading2 is already a number; update the Progress (type="circle") usage to compute size directly as token.fontSizeHeading2 * 2 (remove Number(...)) in the FileList/Progress component so it matches other usages and avoids unnecessary conversion.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/x-sdk/src/chat-providers/OpenAIChatProvider.ts`:
- Around line 56-58: The empty catch in OpenAIChatProvider.transformMessage (and
DeepSeekChatProvider.transformMessage) swallows JSON.parse(chunk.data) errors
and makes them unobservable; update these catch blocks to report the error via a
configurable hook (e.g. new onTransformError option) or reuse
callbacks.onError/processLogger so parse failures are logged/counted (while
preserving the current behavior of not rolling back the assistant message), and
add a unit test that sends an invalid chunk.data and asserts the function
doesn't throw/rollback but does emit the observability event/counter.
---
Nitpick comments:
In `@packages/x/components/attachments/FileList/Progress.tsx`:
- Line 17: The expression size={Number(token.fontSizeHeading2) * 2} is redundant
because token.fontSizeHeading2 is already a number; update the Progress
(type="circle") usage to compute size directly as token.fontSizeHeading2 * 2
(remove Number(...)) in the FileList/Progress component so it matches other
usages and avoids unnecessary conversion.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: a4d9f820-039f-4930-a11f-62c33befc4df
⛔ Files ignored due to path filters (1)
packages/x-markdown/src/plugins/Latex/__tests__/__snapshots__/index.test.tsx.snapis excluded by!**/*.snap
📒 Files selected for processing (14)
packages/x-card/src/A2UI/utils.tspackages/x-sdk/src/chat-providers/DeepSeekChatProvider.tspackages/x-sdk/src/chat-providers/OpenAIChatProvider.tspackages/x-sdk/src/chat-providers/__test__/providers.test.tspackages/x-sdk/src/x-chat/__test__/index.test.tsxpackages/x-sdk/src/x-request/__test__/abort.test.tspackages/x-sdk/src/x-request/__test__/index.test.tspackages/x-sdk/tests/utils.tsxpackages/x/.dumi/pages/index/components/DesignGuide.tsxpackages/x/.dumi/theme/common/ComponentChangelog/ComponentChangelog.tsxpackages/x/components/attachments/FileList/Progress.tsxpackages/x/components/attachments/util.tspackages/x/docs/x-markdown/demo/streaming/format.tsxpackages/x/docs/x-sdk/demos/chat-providers/custom-provider-width-ui.tsx
meet-student
force-pushed
the
codex/fix-optional-chain-lint
branch
from
26ecc08 to
31dd293
Compare
meet-student
force-pushed
the
codex/fix-optional-chain-lint
branch
from
31dd293 to
ff88c3e
Compare
auto-merge was automatically disabled
June 4, 2026 08:15
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log
Summary by CodeRabbit
Bug Fixes
Chores
Tests