Skip to content

Add a way for users to use Number instead of float64 #21

Description

@bterrier

Right now the JSON is parsed using json.Unmarshal() with no way to customize how it is parsed.

However, for some use cases it could be useful to parse with UseNumber() (https://pkg.go.dev/encoding/json#Decoder.UseNumber) so that it is possible to correctly parse numbers that would not fit in a float64.

On way it could be done would be to replace

func parse(b []byte) (*Node, error) {
	var v interface{}
	if err := json.Unmarshal(b, &v); err != nil {
		return nil, err
	}
	doc := &Node{Type: DocumentNode}
	parseValue(v, doc, 1)
	return doc, nil
}

by something like

func ParseInterface(x interface{}) (*Node, error) {
	doc := &Node{Type: DocumentNode}
	parseValue(v, doc, 1)
        return doc, nil
}

func parse(b []byte) (*Node, error) {
	var v interface{}
	if err := json.Unmarshal(b, &v); err != nil {
		return nil, err
	}
	return ParseInterface(v)
}

so that user can either call Parse() and have the current behavior, or call ParseInterface() after doing their own unmarshalling using their own Decoder.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions