Skip to content

Add unit tests for substring function edge cases and non-matching inputs #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
escholtz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add unit tests for substring function edge cases and non-matching inputs #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions xpath_function_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,25 +157,42 @@ func Test_func_string_length(t *testing.T) {
func Test_func_substring(t *testing.T) {
test_xpath_eval(t, empty_example, `substring("motor car", 6)`, " car")
test_xpath_eval(t, empty_example, `substring("metadata", 4, 3)`, "ada")
test_xpath_eval(t, empty_example, `substring("12345", 5, -3)`, "")
test_xpath_eval(t, empty_example, `substring("12345", 1.5, 2.6)`, "234")
test_xpath_eval(t, empty_example, `substring("12345", 0, 1)`, "")
test_xpath_eval(t, empty_example, `substring("12345", 0, 2)`, "1")
test_xpath_eval(t, empty_example, `substring("12345", 0, 3)`, "12")
test_xpath_eval(t, empty_example, `substring("12345", 5, -3)`, "")
test_xpath_eval(t, empty_example, `substring("12345", 0, 5)`, "1234")
test_xpath_eval(t, empty_example, `substring("12345", -1, 4)`, "12")
test_xpath_eval(t, empty_example, `substring("12345", -2, 5)`, "12")
test_xpath_eval(t, empty_example, `substring("12345", -2, 2)`, "")
test_xpath_eval(t, empty_example, `substring("12345", -1)`, "12345")
test_xpath_eval(t, empty_example, `substring("12345", 0)`, "12345")
test_xpath_eval(t, empty_example, `substring("12345", 1, 5)`, "12345")
test_xpath_eval(t, empty_example, `substring("12345", 1, 6)`, "12345")
test_xpath_eval(t, empty_example, `substring("12345", 5, -3)`, "")
test_xpath_eval(t, empty_example, `substring("12345", 1, 0)`, "")
test_xpath_eval(t, empty_example, `substring("12345", 6)`, "")
test_xpath_eval(t, empty_example, `substring("12345", 6, 2)`, "")
test_xpath_eval(t, empty_example, `substring(//non-existent-node, 1)`, "")
test_xpath_eval(t, html_example, `substring(//title/child::node(), 1)`, "My page")
//assertPanic(t, func() { selectNode(empty_example, `substring("12345", 5, "")`) })
}

func Test_func_substring_after(t *testing.T) {
test_xpath_eval(t, empty_example, `substring-after("tattoo", "tat")`, "too")
test_xpath_eval(t, empty_example, `substring-after("tattoo", "tattoo")`, "")
test_xpath_eval(t, empty_example, `substring-after("tattoo", "no-match")`, "")
test_xpath_eval(t, empty_example, `substring-after(//non-existent-node, "tat")`, "")
test_xpath_eval(t, empty_example, `substring-after("tattoo", //non-existent-node)`, "")
test_xpath_eval(t, empty_example, `substring-after("", "tat")`, "")
}

func Test_func_substring_before(t *testing.T) {
test_xpath_eval(t, empty_example, `substring-before("tattoo", "attoo")`, "t")
test_xpath_eval(t, empty_example, `substring-before("tattoo", "tatto")`, "")
test_xpath_eval(t, empty_example, `substring-before("tattoo", "no-match")`, "")
test_xpath_eval(t, empty_example, `substring-before(//non-existent-node, "tat")`, "")
test_xpath_eval(t, empty_example, `substring-before("tattoo", //non-existent-node)`, "")
test_xpath_eval(t, empty_example, `substring-before("", "tat")`, "")
}

func Test_func_sum(t *testing.T) {
Expand Down