New: Add option to ignore browsers - #3
Draft
antross wants to merge 8 commits into
Draft
Conversation
Also fix sorting of options when multiple reports occur at the same location. - - - - - - - - - - - - - - - - - - - - Close webhintio#5224
antross
force-pushed
the
user/tross/ignore-browsers
branch
from
June 29, 2022 22:40
dd7fa6f to
12ac576
Compare
Fixes reports by swapping the name and value of the last prefixed property with the unprefixed version of the property. - - - - - - - - - - - - - - - - - - - - Close webhintio#5223
Creates a new "fix" `CodeAction` when `problem.fixes` exists that contains both an `edit` to communicate the fix to VS Code and a `command` to allow the language server host to detect when a fix has been applied. - - - - - - - - - - - - - - - - - - - - Close webhintio#5227
Lines are 1-based in the JS AST, but columns are 0-based. We need both to be 1-based in the parse5 HTML AST, this was already special-cased for the start tag, but needed to be applied for all column positions.
antross
force-pushed
the
user/tross/ignore-browsers
branch
from
June 30, 2022 22:28
61c0149 to
962438e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Make sure you:
For non-trivial changes, please make sure you also:
Short description of the change(s)